Menu

#5370 \germanChords raises accidentals too high

Fixed
Enhancement
2018-07-13
2018-07-06
No

Malte Meyn wrote :

is there a reason why \germanChords raises accidentals higher than in
other cases? In the past few years I’ve read now several users
complaining about that.

Shouldn’t we remove line 92 (and a closing parenthesis) from
scm/chord-name.scm?

Discussion

  • Malte Meyn

    Malte Meyn - 2018-07-07

    Issue 5370: \germanChords: fix accidental position

    http://codereview.appspot.com/349750043

     
  • Malte Meyn

    Malte Meyn - 2018-07-07
    • assigned_to: Malte Meyn
    • Needs: -->
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-07-07
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-07-07

    passes make. make check and a full make doc

     
  • Anonymous

    Anonymous - 2018-07-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-07-10

    Patch on countdown for July 13th

     
  • Anonymous

    Anonymous - 2018-07-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-07-13

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2018-07-13
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-07-13

    commit d2adf33b9959821a0c074941b249b230fbd089e5
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sat Jul 7 17:41:30 2018 +0200

    Issue 5370: \germanChords: fix accidental position