#5366 Move warnings out of find/create context functions

[Dan Eble]

Move warnings out of find/create context functions

The motivation for this is that Context::find_create_context () and
find_context_near () should probably be merged for maintainability,
but one of the differences between them that must be dealt with is
that find_create_context () logs when it fails and find_context_near
() does not. Adding warnings to find_context_near () risks being too
noisy, leaving the option taken here.

The new method Context::diagnostic_id (name, id) returns a formatted
string (e.g. "Voice" or "Voice = mel") for use in a log message. It
is used for the warnings that are being moved as well as few other
existing warnings to increase consistency.

http://codereview.appspot.com/349740043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for July 7th.

[Anonymous]

Patch on countdown, please push.

[Dan Eble]

commit 51b6513eeeaea69293bd4f554f8021529ae85a49 (HEAD -> pushed/issue-5366-context-warning, origin/staging)
Author: Dan Eble nine.fierce.ballads@gmail.com
Date: Mon Jul 2 13:36:48 2018 -0400

Issue 5366: Move warnings out of find/create context functions

etc.