Menu

#5360 Syntax: fold a few scheme and music functions

Fixed
Maintainability
2018-06-28
2018-06-22
No

Syntax: fold a few scheme and music functions

The functions property-set-function and property-override-function
were music functions internally calling property-set and property-override
functions in the Syntax module for creating music expressions. However,
since issue 4421 music functions were also callable from Scheme rather
than only from the parser so maintaining this distinction is not really
worth the trouble as the performance impact is small.

http://codereview.appspot.com/363720043

Discussion

  • Anonymous

    Anonymous - 2018-06-23

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-06-23
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-06-25
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-25

    Patch on countdown for June 28th.

     
  • Anonymous

    Anonymous - 2018-06-28
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-06-28

    Patch counted down - please push

     
  • David Kastrup

    David Kastrup - 2018-06-28
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2018-06-28

    Pushed to staging as
    commit a031d3b727cbf72f59097d0572aac0798dc6fae6
    Author: David Kastrup dak@gnu.org
    Date: Fri Jun 22 16:28:03 2018 +0200

    Issue 5360: Syntax: fold a few scheme and music functions
    
    The functions property-set-function and property-override-function
    were music functions internally calling property-set and property-override
    functions in the Syntax module for creating music expressions.  However,
    since issue 4421 music functions were also callable from Scheme rather
    than only from the parser so maintaining this distinction is not really
    worth the trouble as the performance impact is small.