Menu ▾ ▴

#5358 Clean up Grob::find_broken_piece and Item::find_prebroken_piece

Fixed
Dan Eble
Fixed_2_21_0 (565)
Maintainability
2018-06-28
2018-06-22
Dan Eble
No

Clean up Grob::find_broken_piece and Item::find_prebroken_piece
with covariant return types and other tweaks.

http://codereview.appspot.com/359730043

Discussion

  • Anonymous

    Anonymous - 2018-06-23
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-06-23

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-06-25
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-06-25

    Patch on countdown for June 28th.

     

  • Anonymous

    Anonymous - 2018-06-28
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-06-28

    Patch counted down - please push

     

  • Dan Eble

    Dan Eble - 2018-06-28
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Maintainability
     

  • Dan Eble

    Dan Eble - 2018-06-28

    commit 7778b337143465ce75babf3d78013e7407239a6c (HEAD -> pushed/issue-5358-grob-find-broken-piece, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Thu Jun 7 21:21:36 2018 -0400

    Issue 5358: Clean up Grob::find_broken_piece and
Item::find_prebroken_piece with covariant return types and other
tweaks.