Menu

#5352 fix CueEndClef with parenthesized ClefModifier

Fixed
Enhancement
2018-06-25
2018-06-20
Malte Meyn
No

fix CueEndClef with parenthesized ClefModifier

If the main clef has a parenthesized or bracketed ClefModifier, ending a
cue now prints those parentheses/brackets.

Contains regtest.

This was reported at the german speaking LilyPond forum: https://lilypondforum.de/index.php?topic=324

http://codereview.appspot.com/353720043

1 Attachments

Discussion

  • Anonymous

    Anonymous - 2018-06-21
    • Description has changed:

    Diff:

    
    
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +Issue_5352_regTest_14-00-42.png (102.0 kB; image/png)
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-06-21

    Passes make, make check and a full make doc - reg test diff attached

     
  • Anonymous

    Anonymous - 2018-06-22
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-22

    Patch on countdown for June 25th.

     
  • Anonymous

    Anonymous - 2018-06-25
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-06-25

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2018-06-25
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-06-25

    commit 538d9ad083659cf8b918120fa17350146df2d9ea
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Wed Jun 20 16:21:30 2018 +0200

    Issue 5352: fix CueEndClefs ClefModifier
    
    If the main clef has a parenthesized or bracketed ClefModifier, ending a
    cue now prints those parentheses/brackets.