Menu

#5347 Add and use a Transform data type

Fixed
Enhancement
2018-06-25
2018-06-16
No

Add and use a Transform data type

As of now, this is just used in stencil-integral. However, a Scheme
level interface would likely make sense for compacting geometric
transformations. The abstraction currently relies on PangoTransform
matrices but could easily be moved to other implementations such as
cairo_matrix_t.

Contains commits:

Add Transform data type

stencil-integral.cc: use Transform

stencil-integral: pass SCM as transform values

http://codereview.appspot.com/344970043

Discussion

  • Anonymous

    Anonymous - 2018-06-16
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-06-16

    Passes make, make check and a full make doc.

     
  • David Kastrup

    David Kastrup - 2018-06-17

    Rebased, reverted to grob rotation for the rotation property.

    http://codereview.appspot.com/344970043

     
  • David Kastrup

    David Kastrup - 2018-06-17
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • David Kastrup

    David Kastrup - 2018-06-17

    Oh for **** sake. This patch has the original GC problem back. I'll need another iteration.

     
  • David Kastrup

    David Kastrup - 2018-06-17
     
  • Anonymous

    Anonymous - 2018-06-17
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-06-17

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-06-19
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-19

    Patch on countdown for June 22.

     
  • David Kastrup

    David Kastrup - 2018-06-21

    Rework according to Dan's review

    http://codereview.appspot.com/344970043

     
  • Anonymous

    Anonymous - 2018-06-21
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-06-21

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-06-22
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-22

    Patch on countdown for June 25th.

     
  • Anonymous

    Anonymous - 2018-06-25
    • Patch: countdown --> push
     
    • David Kastrup

      David Kastrup - 2018-06-25

      "pkx166h" lilypond-pkx@users.sourceforge.net writes:

      • Patch: countdown --> push
      • Comment:

      This looks like it is OK to push - I see some conversation with Hans
      on Rietveld but it doesn't look like it would stop the patch.

      Hans mentioned the introduction of one-shoot classes for disambiguating
      constructor calls without actually proposing any scenario (that I would
      be able to discern) where they would be relevant in connection with this
      patch. To even get to the discussion stage, this would need to be a lot
      more fleshed out in terms of LilyPond code and data.

      --
      David Kastrup

       
  • Anonymous

    Anonymous - 2018-06-25

    This looks like it is OK to push - I see some conversation with Hans on Rietveld but it doesn't look like it would stop the patch.

     
  • Anonymous

    Anonymous - 2018-06-25
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2018-06-25
    Issue 5347/1: Add Transform data type
    author  David Kastrup <dak@gnu.org> 
        Wed, 13 Jun 2018 15:02:10 +0100 (16:02 +0200)
    committer   David Kastrup <dak@gnu.org> 
        Mon, 25 Jun 2018 10:55:16 +0100 (11:55 +0200)
    commit  e73dca0ce5800d5d0d6ec29848e5d43d76d342c8
    
    Issue 5347/2: stencil-integral.cc: use Transform
    author  David Kastrup <dak@gnu.org> 
        Fri, 15 Jun 2018 15:04:30 +0100 (16:04 +0200)
    committer   David Kastrup <dak@gnu.org> 
        Mon, 25 Jun 2018 10:55:16 +0100 (11:55 +0200)
    commit  dd6aa28306839da78d7750cab0856acc26ee9b52
    
    Issue 5347/3: stencil-integral: pass SCM as transform values
    author  David Kastrup <dak@gnu.org> 
        Sat, 16 Jun 2018 08:29:36 +0100 (09:29 +0200)
    committer   David Kastrup <dak@gnu.org> 
        Mon, 25 Jun 2018 10:55:16 +0100 (11:55 +0200)
    commit  bcf29b5699930e959ed9671218c93c52b0d0d22e