#5344 Avoid repeated calculation of accepted contexts

[Dan Eble]

Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context. The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043

[Dan Eble]

Stop uniquifying \accepts; clarify copying

http://codereview.appspot.com/346080043

[Dan Eble]

James, when you run make check, it would be interesting to know whether there are any differences in the profiling results. When I ran make check myself, the results showed 3 cases with a reduction in cell count above the threshold distance. I don't remake my test baseline very frequently, though.

[Anonymous]

Dan,

Sorry I didn't spot this until later. I'll re-run the test and let you know.

[Dan Eble]

test that \with \denies ... has local effect

http://codereview.appspot.com/346080043

[Anonymous]

Passes make, make check and a full make doc

[Anonymous]

Dan, test results here:

https://cloud.indie.host/s/iMYNwKodaWDxCjY

[Anonymous]

Patch on countdown for June 22.

[Anonymous]

Patch counted down, please push.

[Dan Eble]

commit a358ea26328939acdcfb0f08f307bb1c3b076915 (HEAD -> pushed/issue-5344-context-acceptance-set, origin/staging)
Author: Dan Eble nine.fierce.ballads@gmail.com
Date: Sat May 26 19:44:26 2018 -0400

Issue 5344: Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every call to path_to_acceptable_context()
now occurs once when a context is instantiated.