Menu

#5338 Fix out-of-sync LilyScriptEncoding / ps script defs

Fixed
Enhancement
2018-06-24
2018-06-08
No

Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will pass 'make test-baseline/check', but visually the reg testdifferences that do occur are wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen knut_petersen@t-online.de

http://codereview.appspot.com/347870043

Discussion

  • Anonymous

    Anonymous - 2018-06-10
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -3,8 +3,7 @@
     Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
     encodingdefs.ps.
    
    -This patch will not pass 'make check', but this is ok
    -as the current state is wrong.
    +This patch will pass 'make test-baseline/check', but visually the reg testdifferences that do occur are wrong.
    
     I did not care about the 80-characters per line limit,
     it is easier to maintain this format.
    
    • Needs: -->
     
  • Anonymous

    Anonymous - 2018-06-10

    Passes make, make check and a full make doc.

    Reg test diff attached

     
  • Anonymous

    Anonymous - 2018-06-10
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-06-13
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-13

    Patch on countdown for Jun 13.

     
  • Anonymous

    Anonymous - 2018-06-16
     
  • Anonymous

    Anonymous - 2018-06-16

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2018-06-16
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-06-19

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2018-06-21

    Hello Knut, are you waiting for anything specific or do I need to do anything? This patch has hit countdown and can be pushed.

     
  • Knut Petersen

    Knut Petersen - 2018-06-21

    I don't think that I have the necessary rights to push anything. At least I don't know about it. I don't know who pushed my previous patches, but I'm sure it wasn't me ;-)

     
  • Anonymous

    Anonymous - 2018-06-24
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2018-06-24
    author  Knut Petersen <knut_petersen@t-online.de>   
        Sun, 24 Jun 2018 11:33:39 +0100 (11:33 +0100)
    committer   James Lowe <pkx166h@runbox.com> 
        Sun, 24 Jun 2018 12:26:52 +0100 (12:26 +0100)
    commit  68d904661e8539c77d37eba212d97f8cff082c09
    

    Thanks Knut.