Menu

#5337 Create Bottom contexts in a more general way

Fixed
Dan Eble
Enhancement
2020-01-22
2018-06-05
Dan Eble
No

Create Bottom contexts in a more general way

Moving special treatment of "Bottom" into path_to_acceptable_context
() makes it effective during calls to create_unique_context (), which
is the basis of \new and (now) get_default_interpreter ().

http://codereview.appspot.com/339710043

Discussion

  • Anonymous

    Anonymous - 2018-06-07
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-06-07

    Passes make, make check and and a full make doc.

     
  • Anonymous

    Anonymous - 2018-06-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-10

    Patch on countdown for June 13th.

     
  • Anonymous

    Anonymous - 2018-06-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-06-13

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2018-06-14
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2018-06-14

    commit 1c751c5c50c56b85253bba402e24dc16a725a33d (HEAD -> pushed/issue-5337-context-bottom, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sat May 26 07:08:09 2018 -0400

    Issue 5337: Create Bottom contexts in a more general way
    
    Moving special treatment of "Bottom" into path_to_acceptable_context
    () makes it effective during calls to create_unique_context (), which
    is the basis of \new and (now) get_default_interpreter ().
    
     
  • David Kastrup

    David Kastrup - 2019-12-21

    "pkx166h" lilypond-pkx@users.sourceforge.net writes:

    Removal of i.e. and e.g. (and so ugly commas)

    https://codereview.appspot.com/551270043

    That seems a bit drastic, but on second thought i.e. and e.g. suffer
    from the problem of being unpronounceable: nobody reads them loud as "id
    est" or "exempli gratia".

    Somewhat bizarrely, looking the latter up via "dict e.g." yields

    From WordNet (r) 3.0 (2006) [wn]:

    e.g.
    adv 1: as an example; "take ribbon snakes, for example" [syn:
    {for example}, {for instance}, {e.g.}]

    which doesn't even bother mentioning what it stands for.

    --
    David Kastrup

     
  • Anonymous

    Anonymous - 2019-12-21
    • Needs: -->
    • Patch: new -->
    • Type: -->
     
  • Dan Eble

    Dan Eble - 2020-01-22
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Type: --> Enhancement