Menu

#5335 Use covariant return types on virtual Grob::clone()

Fixed
Dan Eble
Maintainability
2018-06-23
2018-06-04
Dan Eble
No

Use covariant return types on virtual Grob::clone()

... and remove unnecessary dynamic_casts.

The casts in the parser were not Grob-related, but since they turned
up during my search, I removed them too.

http://codereview.appspot.com/341320043

Discussion

  • Dan Eble

    Dan Eble - 2018-06-04
     
  • Anonymous

    Anonymous - 2018-06-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-06-05

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2018-06-07
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-07

    Patch on countdown for June 10th

     
  • Anonymous

    Anonymous - 2018-06-10
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-06-10

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2018-06-10
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2018-06-10

    commit 23534338bce94508ddbfbbbd4a746619eb403fd5 (HEAD -> pushed/issue-5335-grob-clone-covariance, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sun Jun 3 19:23:14 2018 -0400

    Issue 5335/2: Remove other unnecessary dynamic_casts
    unrelated to the previous commit
    

    commit 2164bfe5d73b9a660627f43c001ea69453680d68
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sun Jun 3 18:30:17 2018 -0400

    Issue 5335/1: Use covariant return types on virtual Grob::clone()
    and remove unnecessary dynamic_casts.
    
     
  • David Kastrup

    David Kastrup - 2018-06-23
    • Type: Enhancement --> Maintainability
     
MongoDB Logo MongoDB