musicxml2ly: hidden timesigs and tempo marks with text.

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5333 musicxml2ly: hidden timesigs and tempo marks with text.

Status: Fixed

Owner: Alex Myltsev

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-12-05

Created: 2018-06-01

Creator: Alex Myltsev

Private: No

musicxml2ly: hidden timesigs and tempo marks with text.

http://codereview.appspot.com/344000043

Discussion

Alex Myltsev - 2018-06-01

musicxml2ly: hidden timesigs and tempo marks with text.

http://codereview.appspot.com/344000043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-03

Description has changed:

Diff:

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-03

Passes make, make check and a full make doc - there are some comments on Rietveld that may need addressing though.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alex Myltsev - 2018-06-04

Removed the 'test' commits, leaving only changes to Python files.

http://codereview.appspot.com/344000043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-05

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-05

Passes make, make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-07

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-07

Patch on countdown for June 10th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-10

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-10

Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (based against current master) and I can push it for you.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-13

Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (based against current master) and I can push it for you

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alex Myltsev - 2018-06-15

Here are the two commits reviewed above.

0001-musicxml2ly-support-text-bpm-tempo-marks.patch

0002-musicxml2ly-handle-hidden-time-signatures.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-16

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

author  Alexander Myltsev <a.myltsev@gmail.com> 
    Wed, 27 Apr 2016 16:04:43 +0100 (18:04 +0300)
committer   James Lowe <pkx166h@runbox.com> 
    Sat, 16 Jun 2018 10:58:59 +0100 (10:58 +0100)
commit  d751f5fd70d1c4de9878dceb81bda42e9a500fb7

author  Alexander Myltsev <a.myltsev@gmail.com> 
    Thu, 2 Jun 2016 09:19:07 +0100 (11:19 +0300)
committer   James Lowe <pkx166h@runbox.com> 
    Sat, 16 Jun 2018 10:59:08 +0100 (10:59 +0100)
commit  7b07440da921d979ab492fd284b6198152a8020c

Many thanks Alexander.