Menu

#5332 \denies C should cancel \defaultchild C

Fixed
Dan Eble
Enhancement
2018-06-05
2018-05-28
Dan Eble
No

At certain times, LilyPond treats \defaultchild as an implicit \accept with a higher priority than any explicit \accept. When a user intends to change what is acceptable with \denies C, LilyPond should cancel a prior \defaultchild C in addition to a prior \accept C. If \defaultchild C is not cancelled (the behavior of 2.19.80), the context C remains implicitly acceptable.

A related issue that might be addressed at the same time is that LilyPond seems not to honor either \denies or \defaultchild in \with blocks.

Discussion

  • Dan Eble

    Dan Eble - 2018-05-29

    Issue 5332: \denies C should cancel \defaultchild

    This also makes context modifications consistent with context
    definitions in using the last \defaultchild command rather than the
    first.

    http://codereview.appspot.com/346050043

     
  • Anonymous

    Anonymous - 2018-05-30
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-05-30

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-06-01
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-06-01

    Patch on countdown for June 4th

     
  • Anonymous

    Anonymous - 2018-06-05
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-06-05

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2018-06-05
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2018-06-05

    Pushed to staging:

    commit 82954c37b09be22fbb46b00b0bb8e180fcef020c (HEAD -> pushed/issue-5332-context-denies-defaultchild, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Mon May 28 17:16:46 2018 -0400

    Issue 5332/3: \denies C should cancel \defaultchild C
    This commit addresses context modification.
    
    This also makes context modifications consistent with context
    definitions in using the last \defaultchild command rather than the
    first.
    

    commit 52784fdc328d7cb3dde4d5469aec37b170e4a08e
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Mon May 28 17:15:07 2018 -0400

    Issue 5332/2: \denies C should cancel \defaultchild C
    This commit addresses context definition.
    

    commit cbfb6edc8523e5dffdac40aad39f75f9a26522fa
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Mon May 28 17:14:33 2018 -0400

    Issue 5332/1: tests covering \denies and \defaultchild
    
     
MongoDB Logo MongoDB