Menu ▾ ▴

#5329 Improve make-bracket-bar-line

Fixed
Thomas Morley
Fixed_2_21_0 (565)
Enhancement
2018-05-29
2018-05-24
Thomas Morley
No

Improve make-bracket-bar-line

The previously used ly:stencil-scale -1 1 resulted in wrongly positioned
SpanBars in certain cases.
Replaces ly:stencil-scale by flip-stencil.

http://codereview.appspot.com/339670043

Discussion

  • Thomas Morley

    Thomas Morley - 2018-05-24

    A test-case:

    \version "2.19.81"

\defineBarLine "]" #'("]" "" ".")

\new StaffGroup <<
  \new Staff { R1 \bar "]" }
  \new Staff { R1 }
  >>

    current 2.19.81-output attached

     
    Thumbnail
    wrong-span-bar.png

  • Anonymous

    Anonymous - 2018-05-25
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-05-25

    Passes make. make check and a full make doc. I don't see any reg test diffs - should I?

     

  • Thomas Morley

    Thomas Morley - 2018-05-25

    No, the problem arised only, if ]-bar was forced to have a thick span-bar, thus the test-case above.
    We don't have a regtest for this combination. And I think it would be too much to cover every possible combination of bar-lines/span-bars.
    But that's only me ...

     

  • Anonymous

    Anonymous - 2018-05-26
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-05-26

    Patch on countdown for May 29th.

     

  • Anonymous

    Anonymous - 2018-05-29
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-05-29

    Patch counted down - please push.

     

  • Thomas Morley

    Thomas Morley - 2018-05-29
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Thomas Morley

    Thomas Morley - 2018-05-29

    pushed to staging as:

    commit 0d3d026106971592cb58ea9860229ab4a520dc66
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Mon May 21 20:34:17 2018 +0200

    Issue 5329 Improve make-bracket-bar-line

The previously used ly:stencil-scale -1 1 resulted in wrongly positioned
SpanBars in certain cases.
Replaces ly:stencil-scale by flip-stencil.