Menu

#5327 Allow Scheme/identifiers for duration multipliers

Fixed
Enhancement
2018-05-29
2018-05-22
No

Allow Scheme/identifiers for duration multipliers

Also contains commit:

Regtest for computed duration multipliers

http://codereview.appspot.com/346810043

Discussion

  • David Kastrup

    David Kastrup - 2018-05-23

    No good dead goes unpunished. Documentation and harmonization.

    http://codereview.appspot.com/346810043

     
  • Anonymous

    Anonymous - 2018-05-24
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-05-24

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-05-26
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-05-26

    Patch on countdown for May 29th.

     
  • Anonymous

    Anonymous - 2018-05-29
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-05-29

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2018-05-29
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2018-05-29

    Pushed to staging as
    commit ddde3ab8c6fed953f47d5a81a8c95f125bab5e22
    Author: David Kastrup dak@gnu.org
    Date: Wed May 23 22:13:11 2018 +0200

    Issue 5327/6: Documentation for computed duration multipliers
    

    commit 1092286e3744ad231766c69ea2bcc7055a81ff43
    Author: David Kastrup dak@gnu.org
    Date: Tue May 22 22:46:12 2018 +0200

    Issue 5327/5: Regtest for computed duration multipliers
    

    commit 027538606b016afb643555d654cefaee94dfb424
    Author: David Kastrup dak@gnu.org
    Date: Wed May 23 19:08:31 2018 +0200

    Issue 5327/4: Let \afterGrace and \scaleDurations take a scale
    
    That's more versatile than allowing just a fraction as a pair
    as previously.
    

    commit 389fe5b54f091ea599e39a70b7c002af4d1da893
    Author: David Kastrup dak@gnu.org
    Date: Wed May 23 19:06:32 2018 +0200

    Issue 5327/3: Let ly:music-compress take a scale? argument
    
    This makes it less awkward and more generic to use.  Also let the underlying
    functions Music::compress and compress_music_list take a Rational instead
    of a Moment.  That's quite more natural to use here.
    

    commit fb0dc422c8224696b027afc7df6088d836cdc06c
    Author: David Kastrup dak@gnu.org
    Date: Tue May 22 22:45:18 2018 +0200

    Issue 5327/2: Allow Scheme/identifiers for duration multipliers
    

    commit 5bf9fa99a05c11178cb14b163d1c1ab0c2c72dee
    Author: David Kastrup dak@gnu.org
    Date: Wed May 23 17:26:23 2018 +0200

    Issue 5327/1: Add scale? predicate and scale->factor function