Menu ▾ ▴

#5310 find_top_context () instead of get_global_context ()

Fixed
Dan Eble
Fixed_2_21_0 (565)
Maintainability
2019-12-17
2018-04-21
Dan Eble
No

Call find_top_context () rather than get_global_context () where the caller uses the result as a mere Context.

https://codereview.appspot.com/565320043

Discussion

  • Anonymous

    Anonymous - 2018-04-22
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-04-22

    passes make, make check and a full make doc

     

  • Dan Eble

    Dan Eble - 2018-04-22
    • Type: Enhancement --> Maintainability
     

  • Dan Eble

    Dan Eble - 2018-04-22
    • status: Started --> Invalid
    • Patch: review --> abandoned
     

  • Dan Eble

    Dan Eble - 2018-04-26
    • status: Invalid --> Started
    • Patch: abandoned --> needs_work
     

  • Dan Eble

    Dan Eble - 2018-04-26

    Will try introducing a class wrapping a pointer as an annotation that a null pointer is not expected by design.

     

  • Dan Eble

    Dan Eble - 2019-12-13

    Issue 5310: find_top_context () instead of get_global_context ()

    Call find_top_context () rather than get_global_context () where the
    caller uses the result as a mere Context.

    https://codereview.appspot.com/565320043

     

  • Dan Eble

    Dan Eble - 2019-12-13
    • summary: find_top_context () maintenance --> find_top_context () instead of get_global_context ()
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,9 +1,3 @@
-find_top_context () maintenance
-
-* Let find_top_context () deal with references instead of pointers
-  because every non-empty tree has a top.
-
-* Call find_top_context () rather than get_global_context () where the
-  caller uses the result as a mere Context.
-
-http://codereview.appspot.com/341150043
+Call find_top_context () rather than get_global_context () where the caller uses the result as a mere Context.
+  
+https://codereview.appspot.com/565320043
    • Needs: -->
    • Type: --> Maintainability
     

  • Anonymous

    Anonymous - 2019-12-13
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2019-12-13

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2019-12-15
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2019-12-15

    Patch on countdown for 17th December.

     

  • Anonymous

    Anonymous - 2019-12-17
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2019-12-17

    Patch counted down, please push.

     

  • Dan Eble

    Dan Eble - 2019-12-17
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2019-12-17 
    commit 38aac6d602f704aa1c110bf769ed68eec6894d98
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Sat Apr 21 16:00:07 2018 -0400