Menu

#5308 Context code maintenance

Fixed
Dan Eble
Enhancement
2018-04-26
2018-04-20
Dan Eble
No

The only intended change in functionality is to pass an input location through to issue a more useful warning in find_create_context (). The rest is just rearrangement.

http://codereview.appspot.com/346730043

Discussion

  • Dan Eble

    Dan Eble - 2018-04-20
    • summary: Context code maintenance (no functional changes intended) --> Context code maintenance
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,3 @@
    -Context code maintenance (no functional changes intended)
    +The only intended change in functionality is to pass an input location though to issue a more useful warning in find_create_context ().  The rest is just rearrangement.
    
     http://codereview.appspot.com/346730043
    
    • Needs: -->
    • Type: Enhancement --> Maintainability
     
  • Dan Eble

    Dan Eble - 2018-04-20

    actually use the input location (duh)

    http://codereview.appspot.com/346730043

     
  • Anonymous

    Anonymous - 2018-04-20
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-04-20

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-04-21
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-04-21

    Patch on countdown for April 24th

     
  • Dan Eble

    Dan Eble - 2018-04-21
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,3 @@
    -The only intended change in functionality is to pass an input location though to issue a more useful warning in find_create_context ().  The rest is just rearrangement.
    +The only intended change in functionality is to pass an input location through to issue a more useful warning in find_create_context ().  The rest is just rearrangement.
    
     http://codereview.appspot.com/346730043
    
     
  • Anonymous

    Anonymous - 2018-04-24
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-04-24

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2018-04-26
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Dan Eble

    Dan Eble - 2018-04-26

    commit 7602fb5af39a882db488bce7abf8d41ecd9a8c27 (HEAD -> pushed/issue-5308-context-code-maintenance, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Thu Apr 19 18:40:20 2018 -0400

    Issue 5308: Context code maintenance
    
    The only intended change in functionality is to pass an input location
    through to issue a more useful warning in find_create_context ().  The
    rest is just rearrangement.
    
     
MongoDB Logo MongoDB