#5303 layout-set-staff-space confuses chord note head placement in a certain situation

[Simon Albrecht]

Reported by Éric Bellocq:

\version "2.19.80"

\score {
  { <d' f' a'>2 \clef bass <f, a, c> }
  \layout {
    #(layout-set-staff-size 19)
  }
}

This is a regression against 2.18.2.
The problem doesn’t seem to occur on other staff-positions, if set-global-staff-size is used instead, or at other staff sizes.

[Simon Albrecht]

Possibly related, but closed, issue: [#367]

[Carl Sorensen]

The bug does not occur if layout-set-absolute-staff-size is used instead of layout-set-staff-size.
It's not clear to me why whe have both layout-set-staff-size and layout-set-absolute-staff-size. It seems that layout-set-staff-size finds the value of pt in the current module, multiplies that by the size argument, then calls layout-set-absolute-staff-size with the resulting product.
I'm not sure why we do that. Maybe because the paper size could be scaled, which would then scale the staff size according to the scaling.

[Anonymous]

stem.cc - issue 5303 - misplaced notehead

In loop calculating the attachments
of chord node heads to stem,
calculate last used position by
rounding to int rather than by
truncating to int.

This fixes issue 5303 (misplaced note head bug).

Also add regression test.

http://codereview.appspot.com/570830043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

With changes from Lukas based on dev's comments

http://codereview.appspot.com/570830043

[Anonymous]

Passes make, make check and a full make doc

[Anonymous]

Leaving on Review as Rietveld has comments.

[Anonymous]

Patch on countdown for July 13th - Lukas-Fabian, please check reitveld as there are some comments that I cannot see answered.

[Anonymous]

Patch counted down - please push.

[Anonymous]

Issue 5303 - Misplaced Notehead staging
author  Lukas-Fabian Moser <lfm@gmx.de> 
    Thu, 4 Jul 2019 15:18:50 +0100 (16:18 +0200)
committer   James Lowe <pkx166h@runbox.com> 
    Tue, 16 Jul 2019 22:56:13 +0100 (22:56 +0100)
commit  53739c0ae61f7d423633b71620491b869c666404