Menu

#5298 NR 2.7.2, wrong link to scm file

Fixed
Documentation
2018-04-09
2018-03-29
No

Reported yesterday on bug list:

In NR 2.7.2 Displaying chords / Customizing chord names / See also

the line

Installed Files: ‘scm/chords-ignatzek.scm’, ‘scm/chord-entry.scm’, ‘ly/
chord-modifier-init.ly’.

should be

Installed Files: ‘scm/chords-ignatzek-names.scm’, ‘scm/chord-entry.scm’, ‘
ly/chord-modifiers-init.ly’.

(Note that there are two additions in this line, "-names" and "s")

Files to be fixed:

$ git grep -n "@file{scm/chords-ignatzek.scm}" Documentation/
Documentation/de/notation/chords.itely:814:@file{scm/chords-ignatzek.scm},
Documentation/es/notation/chords.itely:775:@file{scm/chords-ignatzek.scm},
Documentation/fr/notation/chords.itely:744:@file{scm/chords-ignatzek.scm},
Documentation/ja/notation/chords.itely:781:@file{scm/chords-ignatzek.scm},
Documentation/notation/chords.itely:733:@file{scm/chords-ignatzek.scm},

Discussion

  • Malte Meyn

    Malte Meyn - 2018-04-01

    Issue 5298: Doc: correct links to installed files

    scm/chords-ignatzek.scm → scm/chords-ignatzek-names.scm

    http://codereview.appspot.com/340620043

     
  • Malte Meyn

    Malte Meyn - 2018-04-01
    • assigned_to: Malte Meyn
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2018-04-02
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2018-04-02

    Passes make, make check and a full make doc.

     
  • Malte Meyn

    Malte Meyn - 2018-04-02

    chord-modifier → chord-modifiers. Should’ve read the issue description more carefully, sorry

    http://codereview.appspot.com/340620043

     
    • Malte Meyn

      Malte Meyn - 2018-04-02

      I’m sorry I didn’t read carefully enough … Honestly I think that you could set it to “Patch: review” without testing again (or at least only make doc) after looking at the changes.

       
  • Anonymous

    Anonymous - 2018-04-02
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2018-04-02

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-04-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-04-06

    Patch on countdown for April 9th.

     
  • Anonymous

    Anonymous - 2018-04-09
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-04-09

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2018-04-09
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-04-09

    commit 57406713bd005022cb2f45ac68add2af1f592a12
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sun Apr 1 15:04:08 2018 +0200

    Issue 5298: Doc: correct links to installed files
    
    scm/chords-ignatzek.scm → scm/chords-ignatzek-names.scm
    ly/chords-modifier-init.ly → ly/chords-modifiers-init.ly
    
     
MongoDB Logo MongoDB