Menu ▾ ▴

#5284 Improve ASSIGN_EVENT_ONCE

Fixed
Dan Eble
Fixed_2_21_0 (565)
Enhancement
2018-03-13
2018-03-04
Dan Eble
No

http://codereview.appspot.com/338540043Improve ASSIGN_EVENT_ONCE

  • Really assign the event only once.
  • End an unnecessary relationship with translator listeners.
  • Rephrase the warning so that it could be used more broadly than for
    simultaneous events.
  • Rephrase the warning so that it could be used with events of
    different classes (e.g. abc-mark-event and xyz-mark-event).
  • Inline the common case that the event is assigned without warning.

http://codereview.appspot.com/338540043

Discussion

  • Dan Eble

    Dan Eble - 2018-03-05

    Test string length & fix white space

    http://codereview.appspot.com/338540043

     

  • Anonymous

    Anonymous - 2018-03-05
    • summary: Issue XXXX: improve ASSIGN_EVENT_ONCE --> Improve ASSIGN_EVENT_ONCE
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,4 @@
-Issue XXXX: improve ASSIGN_EVENT_ONCE
+Improve ASSIGN_EVENT_ONCE

 * Really assign the event only once.
 * End an unnecessary relationship with translator listeners.
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2018-03-05

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-03-07
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-03-07

    Patch on countdown for March 10th

     

  • Dan Eble

    Dan Eble - 2018-03-07
     

  • Anonymous

    Anonymous - 2018-03-09
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2018-03-09

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-03-10
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-03-10

    Patch on countdown for March 13th

     

  • Anonymous

    Anonymous - 2018-03-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,5 @@
-Improve ASSIGN_EVENT_ONCE
+
+http://codereview.appspot.com/338540043Improve ASSIGN_EVENT_ONCE

 * Really assign the event only once.
 * End an unnecessary relationship with translator listeners.
@@ -8,4 +9,5 @@
   different classes (e.g. abc-mark-event and xyz-mark-event).
 * Inline the common case that the event is assigned without warning.

+
 http://codereview.appspot.com/338540043
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-03-13

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2018-03-13
    • labels: --> Fixed_2_21_0
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,3 @@
-
 http://codereview.appspot.com/338540043Improve ASSIGN_EVENT_ONCE

 * Really assign the event only once.
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2018-03-13

    commit 852123e930a9fde9b73293f5d2b2ba52d8ea397b (HEAD -> pushed/issue-5284-event-reassignment-warning, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Fri Mar 2 21:45:26 2018 -0500

    Issue 5284: improve ASSIGN_EVENT_ONCE

* Really assign the event only once.
* End an unnecessary relationship with translator listeners.
* Rephrase the warning so that it could be used more broadly than for
  simultaneous events.
* Rephrase the warning so that it could be used with events of
  different classes (e.g. abc-mark-event and xyz-mark-event).
* Inline the common case that the event is assigned without warning.
     
MongoDB Logo MongoDB