add glyphs for 256th, 512th and 1024th flags and rests

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5277 add glyphs for 256th, 512th and 1024th flags and rests

Status: Fixed

Owner: Malte Meyn

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-03-25

Created: 2018-02-21

Creator: Malte Meyn

Private: No

add glyphs for 256th, 512th and 1024th flags and rests

This post on lilypond-user asks for small rhythmic values (though it doesn’t explicitely mention rests and unbeamed/flagged notes): https://lists.gnu.org/archive/html/lilypond-user/2018-02/msg00614.html

1024th is the shortest duration suggested by SMuFL.

Needs special focus in review:
• forms of downstem flags

Needs improvement but I don’t know how to do:
• dot position for very short rests (see regtest)

Contains also:
• adjust stem lengths for 256th, 512th, and 1024th flags
• Notation Reference: change shortest value from 128th to 1024th
• add very short rests to regtest

http://codereview.appspot.com/336590043

1 Attachments

reg_test_diff_22FEB.png

Discussion

Torsten Hämmerle - 2018-02-21

2nd attempt - previous post deleted because of messed-up formatting

Hi Malte

Good work!

consequent and logical extension of the existing flags and rests

by adapting some Metafont parameters (most notably flagspace, hip_depth_ratio) you managed to maintain the overall "look and feel" even of the downstem flags.

The dot position problem is a mystery yet unsolved and is not "your" new flags' fault.

Stem alignment etc ok

Stem lengths ok

Downstem inner flag/notehead positioning consistent

Rest positioning ok

Donwstem flags
The inner flag has to cope with the notehead, that's why they are slightly wider than the upstem flags. This difference in width gradually vanishes further away from the notehead, that's why the fiddling with flag parameters in Metafont is needed.
I've played around with the values myself and came to about the same solutions as you did.
The differences are barely visible, and, in typography, if it looks equal, it is equal.

All the best,
Torsten
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-22

Description has changed:

Diff:

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +reg_test_diff_22FEB.png (70.3 kB; image/png)

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-22

Passes make, make check and a full make doc - some comments on Rietveld too - reg test diff attached

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Torsten Hämmerle - 2018-02-23

Patch: review --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Torsten Hämmerle - 2018-02-23
  
  I'll have to admit that when commenting about dot column placement, I didn't take a closer look and only had the weird multi-voice effect random placement effect in mind.
  
  The dot placement for the new ultra-short rests has to be adapted, too, because currently, the dots will be placed too low (see attachment).
  I'll drop a note in rieveld (scm/output-lib.scm has to be adapted for duration logs > 7).
  
  All the best
  Torsten
  
  rest-dots.png
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2018-03-18

add Changes entry, add rests to other regtests too, fix dot positions for rests

http://codereview.appspot.com/336590043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-19

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-19

Passes make, make check and a full make doc.

Reg test diffs attached - I am also getting a number of programming errors, but I am not sure if these are those cases where they happen because of the multithreaded testing I do (there are some prog errors that I can ignore or are specific to me).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Malte Meyn - 2018-03-19
  
  I am also getting a number of programming errors, but I am not sure if these are those cases where they happen because of the multithreaded testing I do
  
  I don’t get those programming errors (running both make test-baseline and make check with -j5 CPU_COUNT=5).
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-19

files

2018-03-19-153859_PROGERRORS.png

2018-03-19-153859_REGTEST.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-22

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-22

Patch on countdown for March 25th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-25

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-25

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2018-03-25

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2018-03-25

commit 4895f4237380383d40574c6b3d5351a7be7d1588
Author: Malte Meyn lilypond@maltemeyn.de
Date: Wed Feb 21 14:17:44 2018 +0100

Issue 5277/5: document additions Changes: additions are mentioned Notation Reference: shortest duration is changed to 1024th in some places

commit e84705c85cda260cbb6af8efcbe38cb928d7900c
Author: Malte Meyn lilypond@maltemeyn.de
Date: Wed Feb 21 14:32:40 2018 +0100

Issue 5277/4: add very short rests to regtests

commit 7bc962f8dfb7d328fdc7ea3f530a77a2c61abe34
Author: Malte Meyn lilypond@maltemeyn.de
Date: Wed Feb 21 14:10:42 2018 +0100

Issue 5277/3: adjust stem lengths for flags

commit 876d31ee901bda03fd16ea378fb2fccd5199e30e
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Feb 25 15:20:36 2018 +0100

Issue 5277/2: adapt dots::calc-staff-position This fixes vertical position of dots for 512th and shorter rests. Also, even numbers only are used for smaller duration logs; this fixes the dot position for 32nd/64th rests on four-line and tab staves; I cannot see an effect for duration logs -1, 0, 1 but it seems more logical to use even numbers here too.

commit a7f882e1c37869b6e81b7eacaf5424676f12e719
Author: Malte Meyn lilypond@maltemeyn.de
Date: Wed Feb 21 09:53:55 2018 +0100

Issue 5277/1: add 256th, 512th, and 1024th rests and flags
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: