Menu

#5276 Stop spurious bar lines for large \partial commands

Started
None
needs_work
Enhancement
2018-02-21
2018-02-19
No

Stop spurious bar lines for large \partial commands

Previously \partial commands exceeding one bar of length led to
gratuitous bar lines inserted at multiples of the current bar length.
This stops the Default_bar_line_engraver from inserting bars in these
situations. This allows using \partial for inserting large
intermediate bars without requiring meter changes.

http://codereview.appspot.com/336570043

Discussion

  • Anonymous

    Anonymous - 2018-02-20

    Passes make, make check and a full make doc.

    A lot of reg test diffs

    You can download them from here

    https://cloud.indie.host/s/2Jm75jHAKu8oxcq (~9mb zip file)

     
  • Anonymous

    Anonymous - 2018-02-20
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • David Kastrup

    David Kastrup - 2018-02-20
    • Patch: review --> needs_work
    • Type: Enhancement --> Defect
     
  • David Kastrup

    David Kastrup - 2018-02-20

    Oh wow, this looks really bad. Sorry for not testing more thoroughly: putting down a test baseline and then making a comparison is such a large task for my computer...

     
    • Anonymous

      Anonymous - 2018-02-21

      David, never worry about that. I understand the full make test-baseline/check is rather an arduous task for most devs.

       
  • David Kastrup

    David Kastrup - 2018-02-20

    Fix non-bar when some material takes a multiple of whole measures

    http://codereview.appspot.com/336570043

     
  • Anonymous

    Anonymous - 2018-02-21

    Passes make, make check and a full make doc.

    Reg test diff here - https://cloud.indie.host/s/rMFVfrFz17aI1Ng (~350kb zip)

     
  • Anonymous

    Anonymous - 2018-02-21
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • David Kastrup

    David Kastrup - 2018-02-21
    • Patch: review --> needs_work
     
  • David Kastrup

    David Kastrup - 2018-02-21

    Oh, it's only every \partial at the beginning of a piece now. Sorry for this. I think I should really create a regtest to go along with this and make sure at least the regtest works fine.

     
MongoDB Logo MongoDB