Avoid duplicate rehearsal marks in regression tests

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5275 Avoid duplicate rehearsal marks in regression tests

Status: Fixed

Owner: Dan Eble

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-03-04

Created: 2018-02-18

Creator: Dan Eble

Private: No

Avoid duplicate rehearsal marks in regression tests

Having multiple marks with the same sequence number is something that
LilyPond might reasonably warn about in a future version.

I suppose LilyPond might reasonably warn about out-of-sequence marks,
but I haven't gone that far with this. Let me know if you think I
should.

http://codereview.appspot.com/334510043

Discussion

Dan Eble - 2018-02-18

Description has changed:

Diff:

Needs: -->

Type: Enhancement --> Maintainability
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-19

Passes make, make check and a full make doc.

Reg test diff attached

Reg_test.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-19

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2018-02-20

Fix expected value in test description.
James, you might reasonably choose not to spend time running the tests again for this change.
http://codereview.appspot.com/334510043

Last edit: Dan Eble 2018-02-20

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-21

It's no problem Dan to re-run the test.

Passes make, make check and a full make doc.

Reg_test_21Feb.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-21

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-24

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-24

Patch on countdown for Feb 27th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-27

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-02-27

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-04

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Issue 5275: Avoid duplicating rehearsal marks in regtests master staging
author  Dan Eble <nine.fierce.ballads@gmail.com>    
    Sun, 18 Feb 2018 03:12:24 +0000 (22:12 -0500)
committer   Dan Eble <nine.fierce.ballads@gmail.com>    
    Tue, 20 Feb 2018 17:52:15 +0000 (12:52 -0500)
commit  047e6f2b1b4221c41aa21370731df3fa18bee7a8