Allow left-handed fret-markups
By adding a new boolean subproperty: left-handed.
- Extends Documentation/notation/fretted-strings.itely
- Extends Documentation/changes.tely
- Extenss scm/define-grob-properties.scm
- Adds regtest input/regression/fret-diagrams-left-handed.ly
- Disables the possibility to use negative string-distance
Diff:
I noticed an oversight, so setting it to needs_work. Will correct it in the evening.
David's suggestion
http://codereview.appspot.com/339270043
oversight
http://codereview.appspot.com/339270043
Passes make, make check and a full make doc.
Although I am not sure abou that reg test. Is that what you wanted?
Definitely not!
I didn't touch fret-diagrams-origin.ly, probably an unwanted side-effect.
Will investigate...
Regtest diff
fix glitch exposed by fret-diagram-origin.ly
http://codereview.appspot.com/339270043
passes make, make check and a full make doc.
Patch on countdown for Jan 31st
Patch counted down - please push.
pushed to staging as:
commit e10b92213c1a98e1e3b76df300a022b41e372c8b
Author: Thomas Morley thomasmorley65@gmail.com
Date: Thu Jan 18 20:32:37 2018 +0100
I don't see this new feature in Changes manual on the website... But I can find it in master. Why? Does it actually belong to 2.21?
And I don't see the point of this patch... If I comment (or change to RIGHT) this line in
input/regression/fret-diagrams-left-handed.ly
, nothing changes:It's pushed to master, i.e. 2.21.0
With this version, all's working.
It will not work with 2.19.81, which is build from the stable/2.20 branch.
Same for changes, on the website you see changes for 2.19.81
David K may decide to cherrypick this one for 2.20 or not.
Ok, then I'll wait to mark this issue as verified until it's included in a released version.
Correct the Label to match the comments