LilyIssues / Issues / #5265 Allow left-handed fret-markups

#5265 Allow left-handed fret-markups

Status: Fixed

Owner: Thomas Morley

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2020-01-19

Created: 2018-01-22

Creator: Thomas Morley

Private: No

Allow left-handed fret-markups

By adding a new boolean subproperty: left-handed.
- Extends Documentation/notation/fretted-strings.itely
- Extends Documentation/changes.tely
- Extenss scm/define-grob-properties.scm
- Adds regtest input/regression/fret-diagrams-left-handed.ly
- Disables the possibility to use negative string-distance

http://codereview.appspot.com/339270043

Discussion

Thomas Morley - 2018-01-23

Description has changed:

Diff:

Needs: -->

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-01-23

I noticed an oversight, so setting it to needs_work. Will correct it in the evening.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-01-24

David's suggestion

http://codereview.appspot.com/339270043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-01-24

oversight

http://codereview.appspot.com/339270043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-25

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-25

Passes make, make check and a full make doc.

Although I am not sure abou that reg test. Is that what you wanted?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Thomas Morley - 2018-01-25
  
  Definitely not!
  I didn't touch fret-diagrams-origin.ly, probably an unwanted side-effect.
  Will investigate...
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-25

Regtest diff

screenshot_regtest.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-01-25

fix glitch exposed by fret-diagram-origin.ly

http://codereview.appspot.com/339270043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-26

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-26

passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-28

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-28

Patch on countdown for Jan 31st

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-31

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-01-31

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-01-31

labels: --> Fixed_2_19_21

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-01-31

pushed to staging as:
commit e10b92213c1a98e1e3b76df300a022b41e372c8b
Author: Thomas Morley thomasmorley65@gmail.com
Date: Thu Jan 18 20:32:37 2018 +0100

Allow left-handed fret-markups Issue 5265 By adding a new boolean subproperty: handedness. - Extends Documentation/notation/fretted-strings.itely - Extends Documentation/changes.tely - Extenss scm/define-grob-properties.scm - Adds regtest input/regression/fret-diagrams-left-handed.ly - Disables the possibility to use negative string-distance
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2018-03-09

I don't see this new feature in Changes manual on the website... But I can find it in master. Why? Does it actually belong to 2.21?

And I don't see the point of this patch... If I comment (or change to RIGHT) this line in input/regression/fret-diagrams-left-handed.ly, nothing changes:

\once \override TextScript.fret-diagram-details.handedness = #LEFT
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2018-03-09

It's pushed to master, i.e. 2.21.0
With this version, all's working.

It will not work with 2.19.81, which is build from the stable/2.20 branch.
Same for changes, on the website you see changes for 2.19.81

David K may decide to cherrypick this one for 2.20 or not.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2018-03-10

Ok, then I'll wait to mark this issue as verified until it's included in a released version.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2020-01-19

labels: Fixed_2_19_21 --> Fixed_2_21_0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2020-01-19

Correct the Label to match the comments

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: