Menu

#5261 key-performer.cc: use Pitch::negated for readability

Fixed
Enhancement
2018-01-28
2018-01-15
No

key-performer.cc: use Pitch::negated for readability

This one had been irritating my comprehension, partly because the
argument order for pitch_interval in this use case is not readily
obvious.

http://codereview.appspot.com/333500043

Discussion

  • Anonymous

    Anonymous - 2018-01-16
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-01-16

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-01-19
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-01-19

    Patch on countdown for Jan 22nd

     
  • Anonymous

    Anonymous - 2018-01-22
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-01-22

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2018-01-25

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2018-01-28
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2018-01-28
    author  David Kastrup <dak@gnu.org> 
    Mon, 15 Jan 2018 15:25:26 +0000 (16:25 +0100)
    committer   David Kastrup <dak@gnu.org> 
    Thu, 25 Jan 2018 11:24:06 +0000 (12:24 +0100)
    commit  c99df56de39be96785cc6265e015e01a34f7eb72
    
     
Auth0 Logo