Menu

#5252 fix form of big MMR

Fixed
Enhancement
2018-01-16
2018-01-09
Malte Meyn
No

fix form of big MMR

The horizontal beam should not have rounded corners.

See attached screenshots of before and after the patch.

http://codereview.appspot.com/333490043

2 Attachments

Discussion

  • Malte Meyn

    Malte Meyn - 2018-01-09
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -2,6 +2,6 @@
    
     The horizontal beam should not have rounded corners.
    
    -I’ll attach screenshots of before and after the patch to the SF issue.
    +See attached screenshots of before and after the patch.
    
     http://codereview.appspot.com/333490043
    
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1,2 @@
    +MMR_form.png (1.1 kB; image/png)
    +MMR_form_patched.png (886 Bytes; image/png)
    
    • Needs: -->
     
  • Malte Meyn

    Malte Meyn - 2018-01-10

    To get such a single rest for testing, just use something like

    {
        \compressFullBarRests
        \omit Staff.StaffSymbol
        R1*11
    }
    
     
  • Anonymous

    Anonymous - 2018-01-11
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-01-11

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2018-01-13
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-01-13

    Patch on countdown for Jan 16th.

     
  • Anonymous

    Anonymous - 2018-01-16
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-01-16

    Patch counted down - please push.

    Q. Does this warrant in an entry in Changes.tely? (If so just create a tracker).

     
    • Malte Meyn

      Malte Meyn - 2018-01-16

      I’m not sure whether I understand “warrant” correctly. I don’t think we need a Changes entry, it’s a rather minor fix (I’ve used LilyPond for years now and hadn’t noticed until I worked on issue 3208).

       

      Last edit: Malte Meyn 2018-01-16
  • Malte Meyn

    Malte Meyn - 2018-01-16
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-01-16

    commit d677a2f112a4af3620be2f4598f9cd2cc3461f3d
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Tue Jan 9 22:21:20 2018 +0100

    fix form of big MMR
    
     
MongoDB Logo MongoDB