--- old+++ new@@ -2,6 +2,6 @@The horizontal beam should not have rounded corners.
-I’ll attach screenshots of before and after the patch to the SF issue.+See attached screenshots of before and after the patch.http://codereview.appspot.com/333490043
I’m not sure whether I understand “warrant” correctly. I don’t think we need a Changes entry, it’s a rather minor fix (I’ve used LilyPond for years now and hadn’t noticed until I worked on issue 3208).
Last edit: Malte Meyn 2018-01-16
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Diff:
To get such a single rest for testing, just use something like
Passes make, make check and a full make doc
Patch on countdown for Jan 16th.
Patch counted down - please push.
Q. Does this warrant in an entry in Changes.tely? (If so just create a tracker).
I’m not sure whether I understand “warrant” correctly. I don’t think we need a Changes entry, it’s a rather minor fix (I’ve used LilyPond for years now and hadn’t noticed until I worked on issue 3208).
Last edit: Malte Meyn 2018-01-16
commit d677a2f112a4af3620be2f4598f9cd2cc3461f3d
Author: Malte Meyn lilypond@maltemeyn.de
Date: Tue Jan 9 22:21:20 2018 +0100