Menu

#5249 add a generic markFormatter function

Fixed
Enhancement
2018-01-13
2018-01-01
Malte Meyn
No

add a generic markFormatter function

This uses a modified version of the code as seen at
https://lists.gnu.org/archive/html/lilypond-user/2016-05/msg00156.html

All existing markFormatter functions (like f. e.
format-mark-box-letters) are redefined using format-mark-generic.
Also, the markup commands markletter and markalphabet are redefined and
markgeneric is added.

Documentation strings should be added and it should be mentioned in the
NR. Maybe a better user interface (other than 4 booleans in a row)
would be nice to have.

http://codereview.appspot.com/337400043

Discussion

  • Anonymous

    Anonymous - 2018-01-02
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-01-02

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-01-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-01-04

    Patch on countdown for January 7th.

     
  • Malte Meyn

    Malte Meyn - 2018-01-04

    add doc string for markup command \markgeneric

    http://codereview.appspot.com/337400043

     
  • Malte Meyn

    Malte Meyn - 2018-01-05
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • Malte Meyn

    Malte Meyn - 2018-01-05

    setting to needs_work although it doesn’t fail make et al. because Werner made a good suggestion that I’ll try to realise in that or a similar form: https://codereview.appspot.com/337400043/#msg2

     
  • Malte Meyn

    Malte Meyn - 2018-01-06

    improve user interface, remove markup command \markgeneric

    http://codereview.appspot.com/337400043

     
  • Anonymous

    Anonymous - 2018-01-07
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-01-07

    passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-01-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-01-10

    Patch on countdown for Jan 13th

     
  • Anonymous

    Anonymous - 2018-01-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-01-13

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2018-01-13
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-01-13

    commit 1028a2096e3389af5749b55d6c9cbd28f0b2e835
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Mon Jan 1 21:02:51 2018 +0100

    Issue 5249/2: add regtest
    

    commit 16a3f70519f8f788666620acccd390f946362bcd
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Thu Dec 28 18:25:07 2017 +0100

    Issue 5249/1: add a generic markFormatter function
    
    All existing markFormatter functions (like f. e.
    format-mark-box-letters) are redefined using format-mark-generic. The
    function adds new functionality like oval frames, roman numerals,
    different double letters after Z etc.
    
    Also, the markup commands \markletter and \markalphabet are redefined.
    
     
MongoDB Logo MongoDB