Menu ▾ ▴

#5246 Force crash if no music was found in file

Started
Étienne Beaulé
None
abandoned
Enhancement
2018-05-30
2017-12-21
Étienne Beaulé
No

If nothing gets engraved, there should be an exception, not just a warning, and exiting without error. It seems to be written as a TODO at lily/global-context-scheme.cc:114. It would remove the need to check for the image file(s) in other projects if there is an exception at this level.

Related

Issues: #5234

Discussion

  • Étienne Beaulé

    Étienne Beaulé - 2017-12-22

    Issue #5246: Make empty scores abort engraving process

    This change makes the "no music" warning fatal during the output
    process.

    Issue: 5246

    http://codereview.appspot.com/332470043

     

  • Anonymous

    Anonymous - 2017-12-24
    • assigned_to: Étienne Beaulé
    • Needs: -->
    • Patch: new --> needs_work
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2017-12-24

    This fails make check (reg tests) but I cannot figure out specifically why, there is no one obvious test or error message that is consistent across the failures.

     

  • Étienne Beaulé

    Étienne Beaulé - 2018-05-30
    • Patch: needs_work --> abandoned
     

  • Étienne Beaulé

    Étienne Beaulé - 2018-05-30

    Abandoned.