#5211 Merge_rests_engraver: fix vertical rest positions

[Malte Meyn]

Merge_rests_engraver: fix vertical rest positions

When used with \magnifyStaff the engraver failed to position merged
rests correctly. Using staff-position instead of Y-offset for vertical
positioning fixes this.

http://codereview.appspot.com/334740043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for October 8th

[Malte Meyn]

cleaner solution, added regtests

http://codereview.appspot.com/334740043

[Malte Meyn]

replace moment=? by equal?

http://codereview.appspot.com/334740043

[Anonymous]

Passes make.make check and a full make doc.

[Anonymous]

Patch on countdown for Oct 14th

[Anonymous]

Patch counted down - please push

[David Kastrup]

Please give a pointer to the commit when marking an issue as Fixed.

This has been pushed to staging as
commit b5e8932ebc2bc86d852b5bc1a6e16e2c9c29009d
Author: Malte Meyn lilypond@maltemeyn.de
Date: Fri Oct 6 22:45:38 2017 +0200

Issue 5211/2: add regtest

Add a regtest for Merge_rests_engraver with \magnifyStaff.

Also add a brevis MMR to the original Merge_rests_engraver regtest.

commit 2c01a60d5a6e91e85e133efe1e2550db74aea089
Author: Malte Meyn lilypond@maltemeyn.de
Date: Wed Oct 4 09:58:34 2017 +0200

Issue 5211/1: fix positioning of merged rests

When used with \magnifyStaff the Merge_rests_engraver failed to position
merged rests correctly. Using 'staff-position for Rests and 'direction
for MultiMeasureRests instead of 'Y-offset fixes this.

This also fixes the positioning of brevis MMRs as in
    { \time 4/2 R\breve }

[Malte Meyn]

Thanks for the pointer, I’ll do that next time. It looks like I have to learn some things that aren’t mentioned in the CG or that I overlooked but I’ll try my best to learn fast.

[David Kastrup]

The CG is our best reference for contributors, but that does not mean that it cannot be improved. It tends to be updated as people learn.

[Thomas Morley]

https://www.datamation.com/imagesvr_ce/8378/new-developer.jpg