Menu

#5202 Add regtest for issue 5181

Fixed
Documentation
2017-09-30
2017-09-24
No

Add regtest for issue 5181

Also contains:

Define ly:music-error

http://codereview.appspot.com/327470043

Discussion

  • Anonymous

    Anonymous - 2017-09-24
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-09-24

    Passes make, make check and a full make doc.

     
  • David Kastrup

    David Kastrup - 2017-09-24
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -Add regtest for issue 5191
    +Add regtest for issue 5181
    
    
     Define ly:music-error
    
    • Type: Enhancement --> Documentation
     
  • David Kastrup

    David Kastrup - 2017-09-24
    • summary: Add regtest for issue 5191 --> Add regtest for issue 5181
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,5 +1,7 @@
     Add regtest for issue 5181
    
    +
    +Also contains:
    
     Define ly:music-error
    
     
  • Anonymous

    Anonymous - 2017-09-27
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-09-27

    Patch on countdown for Sept 29th

     
  • Anonymous

    Anonymous - 2017-09-29
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-09-29

    Patch counted down - please push (is there anything additional we/you need to do with regard to Thomas' commenst on Rietveld?)

     
    • David Kastrup

      David Kastrup - 2017-09-30

      Well, tricky. Part of Thomas' comments was more about documenting restrictions: some of them will definitely be permanent, some of them might change. The regtests are more for making sure that features rather than restrictions stay. Warning messages may be considered "features" in certain cases.

      So I likely won't object to further additions along that line but was not really up to proposing something myself.

       
  • David Kastrup

    David Kastrup - 2017-09-30
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2017-09-30

    Pushed to staging as
    commit 71399fe7259f00ffd6a0649fc6b206f30b63d34a
    Author: David Kastrup dak@gnu.org
    Date: Fri Sep 22 18:04:00 2017 +0200

    Issue 5202: Add regtest for issue 5181
    

    commit 92a694f7ecbe37a22c5e58b9c09c70e2b46ec74a
    Author: David Kastrup dak@gnu.org
    Date: Sat Sep 23 23:28:14 2017 +0200

    Define ly:music-error
    
     
  • David Kastrup

    David Kastrup - 2017-09-30
    • labels: --> Fixed_2_21_0
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.