Menu

#5190 NR: Update Clef styles Appendix

Fixed
Documentation
2017-09-30
2017-09-10
No

NR: Update Clef styles Appendix

Added the full range of
Ancient music clefs.

Removed the incomplete
table from the Ancient
music section and gave
an @ref to the appendix.

Added @cindex entries.

http://codereview.appspot.com/324420043

This patch requires https://sourceforge.net/p/testlilyissues/issues/5184/

Discussion

  • Anonymous

    Anonymous - 2017-09-10

    Fix some TexInfo syntax problems

    http://codereview.appspot.com/324420043

     
  • Anonymous

    Anonymous - 2017-09-10
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2017-09-10

    Pass make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-09-10

    Added some @lilypond examples in to ancient.itely

    http://codereview.appspot.com/324420043

     
  • Anonymous

    Anonymous - 2017-09-10
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2017-09-10

    Passes make, make check and a full make doc.

     
  • Phil Holmes

    Phil Holmes - 2017-09-10

    I'd like to have a good look at the examples - I think the noteheads might not always be appropriate to the clefs. Busy tonight and some of tomorrow - can you hold this to give me a chance to look at it on Tuesday? Thanks for the work on this.

     
    • Anonymous

      Anonymous - 2017-09-24

      Phil,

      I took a bit of time to educate myself with Ancient notation and have, hopefully, picked the correct note styles now.

      Should I use the red 4-line-staff for the rest of the examples or just for the Gregorian clefs?

      https://cloud.woelkli.com/s/RohlvM7Gcj5G0yy (new link)

      This is a 300kb PDF of the Ancient Clefs as they will appear in the notation appendix.

       

      Last edit: Anonymous 2017-09-24
  • Anonymous

    Anonymous - 2017-09-13
    • Patch: review --> needs_work
     
  • Anonymous

    Anonymous - 2017-09-13

    Phil has some concerns.

     
  • Anonymous

    Anonymous - 2017-09-24

    Corrected the Note styles. Added more formatting changes.

    http://codereview.appspot.com/324420043

     
  • Anonymous

    Anonymous - 2017-09-24

    Formatting changes as per requests and fixed NoteHead.style value for Hufnagel

    http://codereview.appspot.com/324420043

     
  • Anonymous

    Anonymous - 2017-09-24

    Corrections for Ancient.tely and NoteHead.styles and minor Texinfo correction

    http://codereview.appspot.com/324420043

     
  • Phil Holmes

    Phil Holmes - 2017-09-25

    Patch from a week or so ago, as promised.

     
  • Anonymous

    Anonymous - 2017-09-25
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2017-09-25

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-09-27
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-09-27

    Patch on countdown for Sept 29th

    For those that are interested

    Download PDF examples

    https://cloud.woelkli.com/s/E4PUyPGwxG78F2o (previous patch)

    https://cloud.woelkli.com/s/Du2qOrLlqy5Cjfo (current patch - changes with dev's suggestions)

     
  • Anonymous

    Anonymous - 2017-09-29
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-09-29

    Patch counted down - please push

     
  • Anonymous

    Anonymous - 2017-09-30
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2017-09-30
    author  James Lowe <pkx166h@gmail.com>  
        Sat, 30 Sep 2017 18:03:25 +0100 (18:03 +0100)
    committer   James Lowe <pkx166h@gmail.com>  
        Sat, 30 Sep 2017 18:03:49 +0100 (18:03 +0100)
    commit  d6760214e4e662681333be8e6e4e1c75e4c7c2e8