Menu

#5188 Standardize format of `in_color`

Fixed
Enhancement
2017-09-23
2017-09-09
No

Standardize format of in_color

The skyline line-pair (as used in -ddebug-skylines) used a 0-255 range
for color selection, while other uses use a 0-1 range.

The use of the 0-255 range makes weird output, such as "25500.0000%".

http://codereview.appspot.com/329140043

Discussion

  • Anonymous

    Anonymous - 2017-09-09
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-09-09

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-09-13
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-09-13
     
  • Anonymous

    Anonymous - 2017-09-13

    Patch on countdown for September 16th.

     
  • Étienne Beaulé

    • Patch: countdown --> new
     
  • Étienne Beaulé

    How odd; git-cl didn't update this bug. There's a new patch with some minor tweaks. Changed the status to new. With luck, this will still pass make(s)...

     
  • Étienne Beaulé

    Make Real typing more apparent

    http://codereview.appspot.com/329140043

     
  • Anonymous

    Anonymous - 2017-09-14
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2017-09-14

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-09-16
    • Patch: review --> countdown
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2017-09-16

    Patch on countdown for September 19th

     
  • Anonymous

    Anonymous - 2017-09-20
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-09-20

    Patch counted down - please push to staging.

     
  • Anonymous

    Anonymous - 2017-09-23
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2017-09-23

    author Étienne Beaulé beauleetienne0@gmail.com
    Sat, 9 Sep 2017 18:18:16 +0100 (14:18 -0300)
    committer Étienne Beaulé beauleetienne0@gmail.com
    Wed, 20 Sep 2017 19:47:46 +0100 (15:47 -0300)
    commit 39b793df4ae02d767f054cf1874c71385f9884c2

     
MongoDB Logo MongoDB