Menu

#5184 Add some new mensural clefs and an alias petrucci-g2 to petrucci-g

Fixed
Enhancement
2018-01-13
2017-09-06
No

https://codereview.appspot.com/330120043/

g1 clef occurs in English manuscripts;
f2 clef occurs in Ockeghem's Missa prolationum (Chigi codex)

Discussion

  • Anonymous

    Anonymous - 2017-09-06
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-09-06

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-09-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-09-10

    Patch on countdown for September 13th.

     
  • Anonymous

    Anonymous - 2017-09-13

    Patch counted down - please push (to staging branch Benko, not master)

     
    • Benkő Pál

      Benkő Pál - 2017-09-13

      Patch counted down - please push (to staging branch Benko, not master)

      done as
      $ git log -1
      commit 64d1e85aacc0d04b56ccd9e549e2e27081f8780e (HEAD -> clefs, origin/staging)
      Author: Benkő Pál benko.pal@gmail.com
      Date: Tue Sep 5 19:16:11 2017 +0200

      rarely used mensural clefs
      

      $

      am I to set anything manually?

       
  • Anonymous

    Anonymous - 2017-09-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-09-14
    • labels: --> Fixed_2_20_0
    • status: Started --> Fixed
    • Patch: push -->
     
    • Benkő Pál

      Benkő Pál - 2017-09-17

      2017-09-14 11:02 GMT+02:00 pkx166h lilypond-pkx@users.sf.net:

      labels: --> Fixed_2_20_0
      status: Started --> Fixed
      Patch: push -->
      Comment:

      Hello Benko

      Copy/paste the commit info from git - this allows the bug squad to quickly
      find the checkin.

      Example:

      author Benkő Pál benko.pal@gmail.com
      Tue, 5 Sep 2017 17:16:11 +0000 (19:16 +0200)
      committer Benkő Pál benko.pal@gmail.com
      Wed, 13 Sep 2017 18:04:04 +0000 (20:04 +0200)
      commit 64d1e85aacc0d04b56ccd9e549e2e27081f8780e

      Then set the 'Patch' field blank (select the 'blank' entry above 'push')

      Then set the 'Status' field to 'Fixed'

      Finally make a label that states which build this is fixed in (i.e. the next
      one after the current released unstable) e.g. 'Fixed_2_21_0'

      Save (button located at the end of the thread)

      This all makes the bug sqad's work easier to verify and also for those that
      include the 'issue number' as part of the patch commit message when they
      push makes it easier to see for others whicg build of LP the fix was
      included (i.e. the Fixed version).

      That's it.

      Eventually the bugsquad will change the 'Status' Field to 'Verified' once
      they make sure the tracker has been really 'fixed'.

      Thanks, James. I dimly remembered a similar process from the google
      code era, but haven't found anything in the Contributor's Guide. If
      it's really not there, I'd add some words about it in the 'Pushing to
      staging' section (or a new section after that). Any other ideas?

      p

       
  • Anonymous

    Anonymous - 2017-09-14

    Hello Benko

    Copy/paste the commit info from git - this allows the bug squad to quickly find the checkin.

    Example:

    author  Benkő Pál <benko.pal@gmail.com> 
        Tue, 5 Sep 2017 17:16:11 +0000 (19:16 +0200)
    committer   Benkő Pál <benko.pal@gmail.com> 
        Wed, 13 Sep 2017 18:04:04 +0000 (20:04 +0200)
    commit  64d1e85aacc0d04b56ccd9e549e2e27081f8780e
    

    Then set the 'Patch' field blank (select the 'blank' entry above 'push')

    Then set the 'Status' field to 'Fixed'

    Finally make a label that states which build this is fixed in (i.e. the next one after the current released unstable) e.g. 'Fixed_2_21_0'

    Save (button located at the end of the thread)

    This all makes the bug sqad's work easier to verify and also for those that include the 'issue number' as part of the patch commit message when they push makes it easier to see for others whicg build of LP the fix was included (i.e. the Fixed version).

    That's it.

    Eventually the bugsquad will change the 'Status' Field to 'Verified' once they make sure the tracker has been really 'fixed'.

     
  • Anonymous

    Anonymous - 2017-09-14
    • labels: Fixed_2_20_0 --> FIxed_2_21_0
     
  • Anonymous

    Anonymous - 2017-09-14

    Except of course, I meant Fixed_2_21_0.

    Things that will get included in 2_20_0 I assume will be cherry picked by David et al.

     
  • Malte Meyn

    Malte Meyn - 2018-01-13
    • labels: FIxed_2_21_0 --> Fixed_2_21_0
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.