LilyIssues / Issues / #5177 LilyPad for Windows' Simplified Chinese menu is broken

Masamichi Hosoda - 2017-08-20

I prepared Simplified Chinese environment
(Japanese Windows 10 + Simplified Chinese Language Pack).
It reproduced in the environment.

English menu and Japanese menu are not broken.
Simplified Chinese menu is broken.

lilypad-sc-broken.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-08-20

It seems that binutils (windres) can handle only UTF-8 encoding for non-English strings.
However, Simplified Chinese resource file is not UTF-8 encoding.

I've created a patch that fixes encoding.
https://github.com/trueroad/lilypad/commits/fix-non-english-resource

The attached file is lilypad.exe that patched for testing.

20170820-lilypad.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-08-22

status: New --> Started

Patch: --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-08-22

I assume that there is no code that I can (or need?) to test for this - with regard to make, make check and make doc/reg tests?

I'll set this is on review nonetheless so that it appears on the patch countdown (in case other devs were unaware or missed this new piece of code).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Masamichi Hosoda - 2017-08-22
  
  Yes, there is no code for LilyPond.
  Therefore, make, make check, and make doc/reg tests are unnecessary.
  
  This is for LilyPad. It is not LilyPond.
  LilyPad is a simple text editor bundled with LilyPond for Windows.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-08-25

Mart Jack reported to me that the test lilypad.exe worked.
I've send pull request for LilyPad.
https://github.com/gperciva/lilypad/pull/11

After it is merged, I'll create LilyPad source tarball and pull reqest for GUB.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-08-25

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-08-25

Patch on countdown for August 28th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-08-26

My pull request for LilyPad has been merged.
I've created LilyPad source tarball and pull request for GUB.
https://github.com/gperciva/gub/pull/45

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-08-28

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-08-28

Patch counted down - I'll set this to Push until it has been pulled or pushed or whatever one does with these requests.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-08-28

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-08-28

LilyPad 0.1.3.0 source tarball that is fixed the issue has been uploaded.
http://lilypond.org/downloads/gub-sources/lilypad/lilypad-0.1.3.0-src.tar.xz
My pull request for GUB has been merged.
https://github.com/gperciva/gub/pull/45

The next LilyPond for Windows release will bundle it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-09-13

labels: --> Fixed_2_19_66
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-09-13

We can say that next release (2.19.66) will contain the fix. I've added the label.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-11-02

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-11-02

I cannot verify current LilyPad, but I trust Masamichi

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-11-08

labels: Fixed_2_19_66 -->

status: Verified --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Phil Holmes - 2017-11-08
  
  I'll check before I build the next release.
  
  --
  Phil Holmes
  
  ----- Original Message -----
  From: Masamichi Hosoda
  To: [testlilyissues:issues]
  Sent: Wednesday, November 08, 2017 2:09 PM
  Subject: [testlilyissues:issues] #5177 LilyPad for Windows' Simplified Chinese menu is broken
  
  a.. labels: Fixed_2_19_66 --> b.. status: Verified --> Fixed c.. Comment:
  
  Unfortunately, LilyPad for Windows in LilyPond 2.19.80 is not fixed this issue.
  Its LilyPad has not updated.
  
  Phil, is your local GUB up-to-date?
  Or is this fix for 2.21?
  
  [issues:#5177] LilyPad for Windows' Simplified Chinese menu is broken
  
  Status: Fixed
  Created: Sun Aug 20, 2017 01:26 PM UTC by Masamichi Hosoda
  Last Updated: Thu Nov 02, 2017 01:27 PM UTC
  Owner: Masamichi Hosoda
  
  Mark Jack reported that LilyPad for Windows' Simplified Chinese menu is broken.
  http://lists.gnu.org/archive/html/bug-lilypond/2017-08/msg00019.html
  
  Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/5177/
  
  To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
  
  Related
  
  Issues: ~~#5177~~
  
  alternate
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Phil Holmes - 2017-12-20
  
  Gub has now been updated. The next build should feature a fixed LilyPad.
  
  --
  Phil Holmes
  
  ----- Original Message -----
  From: Masamichi Hosoda
  To: [testlilyissues:issues]
  Sent: Wednesday, November 08, 2017 2:09 PM
  Subject: [testlilyissues:issues] #5177 LilyPad for Windows' Simplified Chinese menu is broken
  
  a.. labels: Fixed_2_19_66 --> b.. status: Verified --> Fixed c.. Comment:
  
  Unfortunately, LilyPad for Windows in LilyPond 2.19.80 is not fixed this issue.
  Its LilyPad has not updated.
  
  Phil, is your local GUB up-to-date?
  Or is this fix for 2.21?
  
  [issues:#5177] LilyPad for Windows' Simplified Chinese menu is broken
  
  Status: Fixed
  Created: Sun Aug 20, 2017 01:26 PM UTC by Masamichi Hosoda
  Last Updated: Thu Nov 02, 2017 01:27 PM UTC
  Owner: Masamichi Hosoda
  
  Mark Jack reported that LilyPad for Windows' Simplified Chinese menu is broken.
  http://lists.gnu.org/archive/html/bug-lilypond/2017-08/msg00019.html
  
  Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/5177/
  
  To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
  
  Related
  
  Issues: ~~#5177~~
  
  alternate
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2017-11-08

Unfortunately, LilyPad for Windows in LilyPond 2.19.80 is not fixed this issue.
Its LilyPad has not updated.

Phil, is your local GUB up-to-date?
Or is this fix for 2.21?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2018-02-04

labels: --> Fixed_2_19_81
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2018-02-04

LilyPad for Windows in LilyPond 2.19.81 is fixed.
Simplified Chinese menu is not broken.

lilypad-sc-nobroken.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2018-03-08

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

LilyPad for Windows' Simplified Chinese menu is broken

Issue Tracker for LilyPond

Searches

Help

#5177 LilyPad for Windows' Simplified Chinese menu is broken

Related

Discussion

Related

Related