#5154 Centering bass figures on whole notes and longer

From: Richard Shann
Subject: Patch to fix centering of some bass figures on whole notes and longer.
Date: Sun, 09 Jul 2017 15:05:18 +0100

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

A test snippet is this:

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<

{

\time 4/2 c''\breve c'' c''1 c''

c''4 c'' c'' c''

}

\new FiguredBass {

\figuremode {

<+>\breve <-> <3>1 <3+>

<+>4 <-> <3> <3+>

}

}

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

In version until now the single character figures are placed to the left
of the true center.

Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043

[Anonymous]

From: David Kastrup
Subject: Re: Patch to fix centering of some bass figures on whole notes and longer.
Date: Sun, 09 Jul 2017 18:46:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Richard Shann address@hidden writes:

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

Except that the "centering" or not decision then rests on the duration
of the bass figure rather than any properties of the note column in
question.

I think it isn't uncommon to have bass lines where there isn't one
figure per bass note but there are also intermediate notes without
figure.

--
David Kastrup

[Anonymous]

From: Richard Shann
Subject: Re: Patch to fix centering of some bass figures on whole notes and longer.
Date: Sun, 09 Jul 2017 17:51:32 +0100

On Sun, 2017-07-09 at 18:46 +0200, David Kastrup wrote:

Richard Shann address@hidden writes:

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

Except that the "centering" or not decision then rests on the duration
of the bass figure rather than any properties of the note column in
question.

I think it isn't uncommon to have bass lines where there isn't one
figure per bass note but there are also intermediate notes without
figure.

Indeed, there are frequently notes without figures (more often than not
in fact) and there are also multiple figures per note, and figures on
rests. Not sure what any of that has to do with this.

In the current LilyPond the figures are centered (visually speaking - I
don't know how they relate to internals such as note column) for
durations greater than 0 but too far to the left for the others (always
referring here to the case of a single figures on a note).

Richard

[Anonymous]

Passes make, make check and a full make doc.

[Thomas Morley]

As David already pointed out this patch looks only at the duration of the BassFigure whether to apply some translation or not. This will only work, if the durations of BassFigure and related note match.

To illustrate:

<<
  \relative c' { c1 c'8 d e f g f e d }
  \figures { <6+>2 <6+>2 <6+>1 }

Only the third BassFigure is moved, but shouldn't!
See attached.

I'd rather go for a procedure looking at NoteColumn, applying it to BassFigure.X-offset or the like to get convincing aligning.

[Thomas Morley]

I now coded such a callback.
See attached.
The file includes the relevant regtest.
Triggered by figured-bass-extenders-markup.ly a design-decision is be needed, how to deal with text-markups.
Needs design-decision as well: how to deal with suspended NoteHeads.

[Anonymous]

This needs some work still - setting the status accordingly - also see Rietveld for othr thread.