Menu

#5147 Add whether to use OTF feature depending on Pango version

Verified
Enhancement
2017-07-18
2017-06-13
No

Add whether to use OTF feature depending on Pango version

Issue 1388 requires Pango 1.38+ for using OpenType font feature.
However, LilyDev 4.1 has Pango 1.36.8.
So it cannot compile Issue 1388.

This commit makes LilyPond can be configured
without OpenType font feature if Pango is old.
Therefore, LilyPond become to be able to compile
even by LilyDev 4.1 that has old Pango.

However, the binary that compiled by LilyDev 4.1
cannot use OpenType feature.
It is required Pango 1.38+ if you'd like to use the feature.

* This patch requires Issue 1388 *
https://sourceforge.net/p/testlilyissues/issues/1388/
https://codereview.appspot.com/323850043

http://codereview.appspot.com/322100043

Discussion

  • Masamichi Hosoda

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -2,7 +2,7 @@
    
     Issue 1338 requires Pango 1.38+ for using OpenType font feature.
     However, LilyDev 4.1 has Pango 1.36.8.
    -So it cannot compile Issue 1338.
    +So it cannot compile Issue 1388.
    
     This commit makes LilyPond can be configured
     without OpenType font feature if Pango is old.
    
    • Needs: -->
     
  • Masamichi Hosoda

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,6 +1,6 @@
     Add whether to use OTF feature depending on Pango version
    
    -Issue 1338 requires Pango 1.38+ for using OpenType font feature.
    +Issue 1388 requires Pango 1.38+ for using OpenType font feature.
     However, LilyDev 4.1 has Pango 1.36.8.
     So it cannot compile Issue 1388.
    
     
  • Anonymous

    Anonymous - 2017-06-14
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-06-14

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-06-16
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-06-16

    patch on countdown for June 20th

     
  • Anonymous

    Anonymous - 2017-06-19
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-06-19

    Patch counted down - please push.

    Hosoda-san can push this at the same time he pushes the fix for https://sourceforge.net/p/testlilyissues/issues/1388

     
  • Masamichi Hosoda

    • labels: --> Fixed_2_19_63
    • status: Started --> Fixed
    • Patch: push -->
     
  • Masamichi Hosoda

    I've pushed to staging.

    commit f75eceb27a4b630d4e898b1d93e3b051f969ff5e
    Issue 5147: Add whether to use OTF feature depending on Pango version

     
  • Federico Bruni

    Federico Bruni - 2017-07-18
    • status: Fixed --> Verified
     
  • Federico Bruni

    Federico Bruni - 2017-07-18

    I've seen the discussion about LilyDev only now. Thanks Masamichi for providing a workaround!

    For the records, the new container and full image I've recently built¹ is based on Fedora 26, where Pango is currently at version 1.40.6.

    ¹ https://lists.gnu.org/archive/html/lilypond-devel/2017-07/msg00047.html

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.