Menu

#5144 lilypond-manuals.css: edit color scheme and some spacing

Verified
Enhancement
2017-07-18
2017-06-10
Paul Morris
No

lilypond-manuals.css: edit color scheme and some spacing

This patch simplifies and (IMHO) improves the color scheme
and spacing of the manuals on the web. I will include a link to
screenshots and a demo site, with more details on what's
different.

http://codereview.appspot.com/322070043

Discussion

  • Paul Morris

    Paul Morris - 2017-06-10

    Here is a screenshot showing the language section in the footer. See reitveld issue for more details and link to demo site.

     
  • Anonymous

    Anonymous - 2017-06-11
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-06-11

    passes make, make check and a full make doc.

     
  • Federico Bruni

    Federico Bruni - 2017-06-12

    Paul, I've been thinking for some time that language selection should be moved to the top, for the following reasons:

    1. It's the place where most people expect the language selection to be. There are obvious reasons for this.
    2. Add to previous argument the fact that links in online manuals are nice links without extension and the browser always serves the file matching the browser language setting (issue [#2273]). So if you happen to use a browser in a language different from the language you'd like to read, you'll need to scroll down each new page to select the right language in the footer.

    Obviously, this belongs to a new issue. But I'm curious to know your opinion.

     

    Related

    Issues: #2273

    • Paul Morris

      Paul Morris - 2017-06-12

      Hi Federico, I'm not opposed to that, in principle. I think the devil is in the details of how it's done, but it's only one line or two of text so that's promising... (I think it would require changes to the code that generates the html, which I think is in Perl, which I don't know.)

       
  • Anonymous

    Anonymous - 2017-06-14
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-06-14

    Patch on countdown for June 17th.

     
  • Anonymous

    Anonymous - 2017-06-16
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-06-16

    Patch counted down - please push.

     
  • Paul Morris

    Paul Morris - 2017-06-17

    Pushed to staging:
    commit 90e4d7057f3857da049dfda3d130017d4719bd6b
    Author: Paul Morris
    Date: Mon May 22 15:02:52 2017 -0400

     
  • Anonymous

    Anonymous - 2017-06-19
    • labels: --> Fixed_2_19_63
    • status: Started --> Fixed
    • Patch: push -->
     
  • Federico Bruni

    Federico Bruni - 2017-07-18
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.