Menu

#5131 Avoid possible segfault in stencil-with-color

Verified
Enhancement
2017-06-04
2017-05-02
No

Avoid possible segfault in stencil-with-color

Check whether the argument is of type color at all

http://codereview.appspot.com/320900043

Discussion

  • Thomas Morley

    Thomas Morley - 2017-05-02

    Test-case:

    \markup 
      \stencil 
        #(stencil-with-color 
          (make-filled-box-stencil '(-1 . 1) '(-1 . 1)) 
          'foo)
    
     
  • Anonymous

    Anonymous - 2017-05-03
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-05-03

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-05-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-05-06

    Patch on countdown for May 9th.

     
  • Anonymous

    Anonymous - 2017-05-09
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-05-09

    Patch counted down - please push.

     
  • Thomas Morley

    Thomas Morley - 2017-05-09
    • labels: --> Fixed_2_19_60
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2017-05-09

    pushed to staging as:

    commit f93965bd56355b8fb01dbfdea8ec2001bfc9d2c2
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Wed May 3 00:58:02 2017 +0200

    Issue 5131 Avoid possible segfault in stencil-with-color
    
    Check whether the argument is of type color at all
    
     
  • Phil Holmes

    Phil Holmes - 2017-05-09
    • labels: Fixed_2_19_60 --> Fixed_2_19_61
     
  • Phil Holmes

    Phil Holmes - 2017-05-09

    19.60 is about to be uploaded.

     
  • Federico Bruni

    Federico Bruni - 2017-06-04
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB