#5129 Bad horizontal spacing when \override LyricText #'X-offset

Dmytro O. Redchuk wrote Friday, April 28, 2017 9:10 AM

please take a look at this MWE:

% --- 8< --------------------
\version "2.19.59"

{ r4 a a2 a4 a2 }
\addlyrics {
\override LyricText #'X-offset = #0
"Блаженні голодні й спрагнені правди, бо вони на" -- си -- тять -- ся.
}
% --- 8< --------------------

I've attached images for 2.18.2, 2.19.59 and 2.19.59 with no \override.

If I missed something and that spacing should be treated in some
special way for such rather extreme cases in 2.19?

Or is there any issue/regression?

[Anonymous]

From Trevor Daniels:

...

The output is correct in 2.18.2 and up to 2.19.9, but wrong from 2.19.10.

The changes in 2.19.10 include Janek's:

Issue 2462 ab6842155a003ba7d9243507594e3e973ebbb3e4

which directly affects lyrics, but there are several other commits which
affect horizontal alignment generally.

Trevor

[Thomas Morley]

For testing I reinserted the line deleted whith issue 2462 on top of recent master:
~~~~
diff --git a/lily/spring.cc b/lily/spring.cc
index d1640e7..5cc4441 100644
--- a/lily/spring.cc
+++ b/lily/spring.cc
@@ -189,6 +189,7 @@ Spring::set_blocking_force (Real f)

blocking_force_ = -infinity_f;
min_distance_ = length (f);
+ distance_ = max (distance_, min_distance_);
update_blocking_force ();
}
~~~~
Now the image comes out exactly as with 2.18.2.
So we have the commit triggering the issue. Can't do more in C++, though.

Probably the ly-code above triggers a corner case, though I'm guessing...

[Dmytro O. Redchuk]

The longer the string ("Блаженні голодні й спрагнені правди, бо вони на") --- the larger the space after each consequent [half] note. So, it's not a corner case, as far as I understand, if we make that string a bit shorter --- we will have a bit smaller "extra space" (compared to 2.18's output).

[Dmytro O. Redchuk]

Please, is there any hope that this regression will be fixed?

2.20.0 adds that "extra space" too.

Thank you anyway :)