Menu

#5127 Implement extra-offset for system positioning

Verified
Enhancement
2017-05-11
2017-04-27
No

Implement extra-offset for system positioning

Add the property 'extra-offset to 'line-break-system-details.

It is possible to position systems absolutely using the properties
'X-offset and 'Y-offset of 'line-break-system-details. Placement,
however, is relative to the top left of the usable space, and can
be difficult to gauge without considerable trial and error.

An 'extra-offset property allows easy movement of systems relative
to where they currently are on the page--either through their
default positioning, or as a result of absolute positioning through
'X-offset and/or 'Y-offset.

System separators will be properly positioned. (Thanks go to Thomas
Morley.)

http://codereview.appspot.com/324810043

Discussion

  • David Nalesnik

    David Nalesnik - 2017-04-28

    Changes based on Harm's review

    http://codereview.appspot.com/324810043

     
  • Anonymous

    Anonymous - 2017-04-29
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2017-04-29

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-05-03
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-05-03

    Patch on countdown for May 6th.

    (although can you check David K's comments on Rietveld in case you have not already seen them?).

     
  • David Nalesnik

    David Nalesnik - 2017-05-03

    I checked them. They shouldn't hold back this particular patch.

     
  • Anonymous

    Anonymous - 2017-05-06
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-05-06

    Patch counted down - please push.

     
  • David Nalesnik

    David Nalesnik - 2017-05-06
    • labels: --> Fixed_2_19_60
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Nalesnik

    David Nalesnik - 2017-05-06

    Pushed to staging as commit 24dd6365d3d05f13b9259f547be9b2517851a5d1.

     
  • Federico Bruni

    Federico Bruni - 2017-05-11
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB