#5124 Slashed Half-flat and add. scales for Arabic music

[Amir Czwink]

Slashed Half-flat and add. scales for Arabic music

-Introduced a glyph list so that the slashed half-flat is used (always) instead of the mirrored one (the latter is never used for Arabic sheet music)
-Added two scales (Maqamat) of major importance for Arabic music

For arabic music score writing: -Introduced new glyph list, so that by default the slashed half-flat is used instead of the mirrored half-flat, which isn't used in Arabic score writing. This makes the use of the cumbersome \dwn symbol needless and obsolete -Added Hijaz and Hijaz-Kar maqamat

http://codereview.appspot.com/317550043

[Anonymous]

Passes make, make check and a full make doc.

Reg test output here - 350Kb (zip file)

https://cloud.woelkli.com/s/18fMg3XJuN9tXas

(note I can never tell if these 'programming errors' are those odd ones that I often have to ignore - however normally in that case it is the same error over and over. This patch however generates two distinct errors, as well as the reg test diffs).

[David Kastrup]

The change in midi-key-signature.ly looks like something that would affect Turkish music. Anybody with more of a clue than me?

[Amir Czwink]

That change, if I'm not mistaken, is correct. Because in this test, "arabic.ly" is included and an arabic maqam (scale) is used (bayati in this case). As I wrote in the patch description in Arabic music the slashed half-flat is used for the "-quarter" accidental instead of the mirrored b.
For turkish music, "makam.ly" has to be included instead of "arabic.ly" and with this, one should still get the mirrored b.

Therefore in my opinion this is a correct change.

[David Kastrup]

You are the expert here.

The other spacing changes are irritating, to say the least. Sometimes changes bleed over into future files processed by the same run of the lilypond executable, and then seemingly independent tests may get triggered. Not sure whether this is the case here or whether this shows us some instability recently introduced.

[Amir Czwink]

I don't understand why this is happening. For instance "test-output-distance.ly" does not even include arabic.ly
How is it possible that this tests changes because of a file that the test doesn't use?

[David Kastrup]

test-output-distance.ly always changes. It's for testing the regression tests.

[Amir Czwink]

removed trailing white spaces

http://codereview.appspot.com/317550043

[Amir Czwink]

fixed format issues

http://codereview.appspot.com/317550043

[Amir Czwink]

removed unnecessary comments

http://codereview.appspot.com/317550043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for May 3rd.

[Anonymous]

Patch counted down - please push.

Amir, if you do not have push permissions, you can attach a git formatted patch to this incident (based on current master) and I can push it for you.

[Amir Czwink]

It seems that I don't have the rights.
Is the attachment what you've asked for?

Anyway thanks for your support :)

[Thomas Morley]

Hi Amir,

the formated patch doesn't match the most recent and reviewed patchset on Rietveld!!

[Amir Czwink]

so then it should be this one...

[Amir Czwink]

Sorry I don't know exactly how to do it... I attached the four patches that I made concerning this issue...

[Thomas Morley]

I grabbed the diff above and the commit-message from Rietveld and pushed it to staging as:

commit 6f2916047111d80326f15e67ede30cddbbeedbb4
Author: Amir Czwink amir130@hotmail.de
Date: Fri May 5 00:13:43 2017 +0200

Slashed Half-flat and add. scales for Arabic music

-Introduced a glyph list so that the slashed half-flat is used
(always) instead of the mirrored one (the latter is never used
for Arabic sheet music)
-Added two scales (Maqamat) of major importance for Arabic music

For arabic music score writing:
-Introduced new glyph list, so that by default the slashed
half-flat is used instead of the mirrored half-flat, which isn't
used in Arabic score writing. This makes the use of the cumbersome
\dwn symbol needless and obsolete
-Added Hijaz and Hijaz-Kar maqamat