Menu

#5123 Improve elbowed-hairpin

Verified
Enhancement
2017-05-11
2017-04-22
No

Improve elbowed-hairpin

Let the lines be printed by the new make-connected-line-procedure,
using ly:line-interface::line. The new stencil now reacts on
overrides for style and dash-period/fraction.
Not closing Hairpins created by elbowed-hairpin are possible now.
Single disadvantage: The point-list needs to have (0 . 0) first,
if a closing Hairpin is wished.
The previous used make-connected-path did that automatically and
thus was not flexible enough.

Give the final stencil proper extents.

Cleanup, more descriptive naming, extent docstring.

http://codereview.appspot.com/324800043

Discussion

  • Anonymous

    Anonymous - 2017-04-23
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-04-23

    Passes make, make check and a full make doc.

     
  • Thomas Morley

    Thomas Morley - 2017-04-24

    Adressing David N's comments, extend docstring

    http://codereview.appspot.com/324800043

     
  • Anonymous

    Anonymous - 2017-04-25
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2017-04-25

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-04-27
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-04-27

    Patch on countdown for April 30th.

     
  • Anonymous

    Anonymous - 2017-04-30
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-04-30

    Patch counted down - please push.

     
  • Thomas Morley

    Thomas Morley - 2017-04-30
    • labels: --> Fixed_2_19_60
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2017-04-30

    pushed to staging as:

    commit 605634765732eab978057b8a1af7efe641c81049
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Sat Apr 22 19:48:13 2017 +0200

    Issue 5123 Improve elbowed-hairpin
    
    Let the lines be printed by the new make-connected-line-procedure,
    using ly:line-interface::line. The new stencil now reacts on
    overrides for style and dash-period/fraction.
    Not closing Hairpins created by elbowed-hairpin are possible now.
    Single disadvantage: The point-list needs to have (0 . 0) first,
    if a closing Hairpin is wished.
    The previous used make-connected-path did that automatically and
    thus was not flexible enough.
    
    Give the final stencil proper extents.
    
    Cleanup, more descriptive naming, extent docstring.
    
     
  • Federico Bruni

    Federico Bruni - 2017-05-11
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB