#5122 Fix not scaling stem in note-by-number-markup

[Thomas Morley]

Fix not scaling stem in note-by-number-markup

Done by calling text-font-size from layout, which defaults to 11.
Then scaling stem-thickness and stem-length by division of
text-font-size through 11.
This ensures a stem-appearance according to the text-properties of
MetronomeMark.

http://codereview.appspot.com/324780043

[Thomas Morley]

Code-example:

\version "2.19.56"

mus = 
\new Staff { 
  \tempo 8=120 
  c'2_\markup 
        \line {
            \fontsize #-6 \note-by-number #3 #0 #UP
            \fontsize #-4 \note-by-number #3 #0 #UP
            \fontsize #-2 \note-by-number #3 #0 #UP
            \fontsize #0 \note-by-number #3 #0 #UP
            \fontsize #2 \note-by-number #3 #0 #UP
            \fontsize #4 \note-by-number #3 #0 #UP
            \fontsize #6 \note-by-number #3 #0 #UP
        }
}

\score {
  \mus
  \layout { #(layout-set-staff-size 10) }
}

\score {
  \mus
  \layout { #(layout-set-staff-size 20) } 
}

\score {
  \mus
  \layout { #(layout-set-staff-size 40) } 
}

[Thomas Morley]

Isn't it possible to attach two images?

[Anonymous]

Yes, you need to multi-select the images in the same 'post' when you browse for them, else you end up posting them one at a time. I have removed your attachments and 'reposted' them at the top of the issue for convenience of anyone else.

[Thomas Morley]

give text-font-size a fallback-value

http://codereview.appspot.com/324780043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for April 24th

[Anonymous]

Patch counted down - please push.

[Thomas Morley]

pushed to stagung as:

commit eee677c480c78d58a5215e246575aa94ba2d1897
Author: Thomas Morley thomasmorley65@gmail.com
Date: Sun Apr 16 17:11:05 2017 +0200

Issue 5122 Fix not scaling stem in note-by-number-markup

Done by calling text-font-size from layout, which defaults to 11.
Then scaling stem-thickness and stem-length by division of
text-font-size through 11.
This ensures a stem-appearance according to the text-properties of
MetronomeMark.

[Joël Riou]

This patch may have broken the rendering of metronomic marks in case the staff size was set with set-global-staff-size.

For the following simple source code, the stem of the metronomic mark is ok with version 2.19.55, but it is not with version 2.19.61 after the patch was applied:

\version "2.19.55"

(set-global-staff-size 11 )

\score {
\new Staff {
\tempo 8 = 140
c'4
}
}

[Thomas Morley]

Confirmed.
On devel I suggested to revert this patch.

[Thomas Morley]

This is now Issue 5231 Fix regression introduced with 5122 "Fix not scaling stem ..."
https://sourceforge.net/p/testlilyissues/issues/5231/