Add a \voicify command

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5114 Add a \voicify command

Status: Verified

Owner: David Kastrup

Labels: Fixed_2_19_60 (13)

Needs:

Patch:

Type: Enhancement

Updated: 2017-05-11

Created: 2017-04-03

Creator: David Kastrup

Private: No

Add a \voicify command

Also contains commits:

Document \voicify

Add regtest for \voicify

Let voicify-music receive an optional id list

http://codereview.appspot.com/320820043

Discussion

David Kastrup - 2017-04-03

Actual patch after establish issue 5113 baseline in patch set 1

http://codereview.appspot.com/320820043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-03

Description has changed:

Diff:

Needs: -->

Patch: new --> needs_work

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-03

This fails make doc:

--snip--

Error posted in notation.splittexi.log:

** dots requires {} (in out-www/identifiers.texi l. 738) *** '{' without macro. Before: } \\ @dots {} \\ @dots {} >> (in out-www/identifiers.texi l. 738) Max error number exceeded

Line 738 in identifiers.texi is this @example construct:

@example \voicify 1,2,3 << @dots {} \\ @dots {} \\ @dots {} >> @end example

It's the white space between the macro and the curly brackets

This appears in the file:

https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-04-03

Fix documentation problems (and some formatting)

http://codereview.appspot.com/320820043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-04

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-04

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-06

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-06

Patch on countdown for April 9th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-09

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-09

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-04-09

Fix the error behavior, rename \voicify to \voices

http://codereview.appspot.com/320820043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-11

Needs: -->

Patch: new --> needs_work

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-11

Fails make check - I cannot quickly see why (it's one of those cases where it fails on one or more of the lilypond-book commands but multiple ly files are listed). I'll dig some more to see if I can spot which is failing where. I've run the test three times on less -Jx options (if you go below 2 make doc takes about 2 hours) and it fails at the same point, so this isn't just my own box or running at very high -J counts.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-11

\sourcefilename "/home/jlowe/lilypond-git/input/regression/voices-command.ly"

This looks like the problem.

--snip--

Processing `./47/lily-9e7965fb.ly' Parsing... Renaming input to: `/home/jlowe/lilypond-git/input/regression/voices-command.ly'/home/jlowe/lilypond-git/build/out/share/lilypond/current /scm/music-functions.scm:960:12: In procedure voicify-sublist in expression (voicify-sublist sublist (symbol->string id)): /home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/music-functions.scm:960:12: Wrong number of arguments to #<procedure voicif y-sublist (loc sublist id)>
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- David Kastrup - 2017-04-11
  
  Consider me annoyed, and thanks for sweeping after me. I'll try to find out how I messed up this time.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - David Kastrup - 2017-04-11
    
    Bad code, and the regtest itself shows it up. One could have expected to check at least that the regtest still works after making a major change, couldn't one?
    
    Sorry for the extra work.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-04-11

Fix stupid blunder/omission

http://codereview.appspot.com/320820043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-13

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-04-13

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-04-14

labels: --> Fixed_2_19_60

status: Started --> Fixed

Patch: review -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-04-14

Since most of the discussion already happened around the first countdown/push and this was about bugs in the implementation, I am pushing to staging without further ado as
commit 4244c3a9fbf1f3ff2e20e665f92516d35b61de53
Author: David Kastrup dak@gnu.org
Date: Mon Apr 3 00:25:10 2017 +0200

Issue 5114/4: Document \voices

commit 93be41a1622bc33a01719d1d75af3dca40d75354
Author: David Kastrup dak@gnu.org
Date: Sun Apr 2 17:52:28 2017 +0200

Issue 5114/3: Add regtest for \voices

commit 40dc095e51ecfe198b9209e2a1612d44325a4bfb
Author: David Kastrup dak@gnu.org
Date: Sat Apr 1 13:25:57 2017 +0200

Issue 5114/2: Add a \voices command

commit 13165dec9fb20fdeef2612b0d0c8276584cc9d15
Author: David Kastrup dak@gnu.org
Date: Sat Apr 1 11:52:10 2017 +0200

Issue 5114/1: Let voicify-music receive an optional id list
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-05-11

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: