#5110 Lyric hyphens remain black even after override

[Phil Holmes]

http://codereview.appspot.com/323410043

Urs Liska reported:

In the following code the hyphen separating the
lyrics syllables would be printed red:

\version "2.19.57"

\layout {
\context {
\Lyrics
\override LyricHyphen.color = #red
\override LyricText.color = #blue
\override LyricExtender.color = #magenta
}
}

music = {
c'2 c'2 ~ c'1
}

text = \lyricmode {
Hel -- lo __
}

<<
\new Staff \new Voice = "mel" \music
\new Lyrics \lyricsto "mel" \text

But as you can see in the attached image it remains black, while the
extender and the text itself are correctly colored.

David Kastrup said:

This is a regression due to

commit 2dc76513c4edb8e18e6170069677eb0dd9b54209
Author: Knut Petersen knut_petersen@t-online.de
Date: Sat Mar 4 18:10:19 2017 +0000

LyricHyphen whiteout

Issue 5033

[Knut Petersen]

That patch should help.

Knut

[Anonymous]

Fix issue 5110: Don't use fixed color for LyricHyphens

Signed-off-by: Knut Petersen knut_petersen@t-online.de

http://codereview.appspot.com/323410043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for August 14th

[Anonymous]

Patch counted down - please push.

@Knut this is one of yours. So if you want to push it yourself (I cannot recall if you have commit access or not) then feel free, else let me know and I can do it on your behalf.

[Knut Petersen]

I cannot recall if you have commit access

As far as I remember I don't have commit access ;-)

[Anonymous]

author Knut Petersen knut_petersen@t-online.de
Wed, 26 Jul 2017 11:36:38 +0100 (12:36 +0200)
committer James Lowe pkx166h@gmail.com
Wed, 16 Aug 2017 07:44:15 +0100 (07:44 +0100)
commit e8b2544334fa66858c09028719fa82c447037291