Menu

#5100 Prevent race condition in font export directory making

Verified
Enhancement
2017-04-02
2017-03-16
No

Prevent race condition in font export directory making

When a font export directory is necessary,
LilyPond tested the existence of the directory,
and if the directory did not exist, LilyPond made the directory.
However, LilyPond raised the error that the directory already exists
if another process made the directory between the testing and the making.

This commit prevents such race condition.
By deleting the existence test,
LilyPond always tries to make the directory regardless of existence.
Then suppress the error that the directory already exists.

http://codereview.appspot.com/319510043

Discussion

  • Anonymous

    Anonymous - 2017-03-17
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-03-17

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-03-19
    • Patch: review --> needs_work
     
  • Anonymous

    Anonymous - 2017-03-19

    Comment from David Kastrup in Rietveld.

     
  • Masamichi Hosoda

     
  • Anonymous

    Anonymous - 2017-03-19
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2017-03-19

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-03-22
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-03-22

    Patch on countdown for March 25th.

     
  • Anonymous

    Anonymous - 2017-03-25
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-03-25

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2017-03-25
    • labels: --> Fixed_2_19_58
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2017-03-25

    author Masamichi Hosoda trueroad@trueroad.jp
    Thu, 16 Mar 2017 11:42:15 +0000 (20:42 +0900)
    committer Masamichi Hosoda trueroad@trueroad.jp
    Sat, 25 Mar 2017 11:42:13 +0000 (20:42 +0900)
    commit 20c99b5f4bd928ad865025e0649f6c7515e2f358

     
  • Graham Percival

    Graham Percival - 2017-04-02
    • status: Fixed --> Verified
     
  • Graham Percival

    Graham Percival - 2017-04-02

    Verified commit in git.