LilyIssues / Issues / #5099 Fix regtest scheme-engraver.ly wrt to guile-2.2

#5099 Fix regtest scheme-engraver.ly wrt to guile-2.2

Status: Verified

Owner: Thomas Morley

Labels: Fixed_2_19_58 (15)

Needs:

Patch:

Type: Enhancement

Updated: 2017-04-02

Created: 2017-03-15

Creator: Thomas Morley

Private: No

Fix regtest scheme-engraver.ly wrt to guile-2.2

Passing a number to format as the port is deprecated in guile-2.2
Thus using (current-error-port) instead

http://codereview.appspot.com/322720043

Discussion

Thomas Morley - 2017-03-16

Btw, while grepping for "format 1" an entry in a comment in midi-chunk.cc is found.
Though, I feel not knowledgeable enough to judge about.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-16

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-16

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-19

Comment from David K in Rietveld.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-19

Patch: review --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-03-19

Patch: needs_work --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-03-19

There's probably a misunderstanding.
I've understood David this way: "Don't bother about variables, it's ok as it is."

So I set this back to review.
David, if I'm wrong here, please shout.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-22

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-22

Patch on countdown for March 25th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-25

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-25

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-03-25

labels: --> Fixed_2_19_58

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-03-25

Pushed to staging as:

commit fa2ab0d0c049e84e6b6a4839710f849cbbc61d08
Author: Thomas Morley thomasmorley65@gmail.com
Date: Wed Mar 15 00:20:22 2017 +0100

Issue 5099 Fix format in input/regression/scheme-engraver.ly Passing a number to format as the port is deprecated Now always doing (format #t ...)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Graham Percival - 2017-04-02

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Graham Percival - 2017-04-02

Verified commit in git.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: