LilyIssues / Issues / #5084 Create Bracket class

#5084 Create Bracket class

Status: Verified

Owner: David Nalesnik

Labels: Fixed_2_19_57 (12)

Needs:

Patch:

Type: Enhancement

Updated: 2017-04-03

Created: 2017-03-06

Creator: David Nalesnik

Private: No

Issue 5084: Create Bracket class

Code involving brackets suffers from two confusing
organizational issues:

(1) Tuplet_bracket::make_bracket is used to create brackets
for a number of grobs: BassFigureBracket, HorizontalBracket,
OttavaBracket, PianoPedalBracket, VoltaBracket, along with
TupletBracket

(2) Methods belonging to Horizontal_bracket are used to draw
both horizonal brackets (HorizontalBracket) and vertical
brackets (BassFigureBracket)

To remedy this, a new Bracket class is created.

This new class contains the old Tuplet_bracket::make_bracket,
Horizontal_bracket::make_bracket, and
Horizontal_bracket::make_enclosing_bracket.

These methods have been renamed to clarify their purpose.

http://codereview.appspot.com/314610043

Discussion

Anonymous - 2017-03-08

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-08

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-10

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-10

Patch on countdown for March 13th,

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-13

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-03-13

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-03-13

labels: --> Fixed_2_19_57

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,4 @@ -Create Bracket class +Issue 5084: Create Bracket class Code involving brackets suffers from two confusing organizational issues:

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-03-13

Pushed to staging as

author David Nalesnik david.nalesnik@gmail.com
Thu, 23 Feb 2017 10:57:44 -0500 (09:57 -0600)
committer David Nalesnik david.nalesnik@gmail.com
Mon, 13 Mar 2017 13:15:50 -0500 (13:15 -0500)
commit 9e877e5aea3fb6cf6e7873d1e8797672cda450f5

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Graham Percival - 2017-04-03

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Create Bracket class

Issue Tracker for LilyPond

Searches

Help

#5084 Create Bracket class

Discussion