Menu

#5083 Add making web.$(ISOLANG).pdf

Verified
Enhancement
2017-04-16
2017-03-06
No

Add making web.$(ISOLANG).pdf

English document web.pdf is built by `make doc'.
However, i18n (non-English) document web.$(ISOLANG).pdf is not built.

This commit adds making web.$(ISOLANG).pdf.

http://codereview.appspot.com/319450043

Related

Issues: #3107
Issues: #5083

Discussion

  • Anonymous

    Anonymous - 2017-03-06
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-03-06

    Passes make, make check and a full make doc.

     
  • Federico Bruni

    Federico Bruni - 2017-03-07

    I guess that issue [#3107] should be closed once this has been pushed and verified

     

    Related

    Issues: #3107

  • Masamichi Hosoda

    If I understand correctly, issue [#3107] contains two problems.
    One is that the non-English Web.??.pdf is not built.
    Another one is that some links from non-English pages are English web.pdf instead of non-English web.??.pdf.

    This issue [#5083] will solve the former one.
    However, the latter one is not solved.

    I'll create a patch for solving the latter one.

     

    Related

    Issues: #3107
    Issues: #5083

  • Federico Bruni

    Federico Bruni - 2017-03-08

    The latter issue does not exist, as you can see from this page:
    http://lilypond.org/website/web.it.html

    where you can see that there's a link to the file web.it.pdf, resulting in a 404 error because of this bug you've just fixed.
    Spanish translator made a different choice: he preferred not having a 404 error and linked to the english document. So he wrote in Documentation/es/web/manuals.itexi:

    @docLinksBare{Web, web,
      @ref{Arriba,Web},
      @manualDevelWebSplit-es,
      @manualDevelWebBig-es, 2.5 MB,
      @manualDevelWebPdf, 3.5 MB}
    
    @divEnd
    

    Note the missing -es extension in the third manual link.
    So it's up to translators to fix it.

    $ git grep @manualDevelWebPdf Documentation/
    Documentation/ca/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf}
    Documentation/ca/web/manuals.itexi:  @manualDevelWebPdf, 3.5 MB}
    Documentation/cs/web/community.itexi:@docLinkPdf{Webseite,web,@manualDevelWebPdf-cs}
    Documentation/cs/web/manuals.itexi:  @manualDevelWebPdf, 2 MB}
    Documentation/de/web/community.itexi:@docLinkPdf{Webseite,web,@manualDevelWebPdf-de}
    Documentation/de/web/manuals.itexi:  @manualDevelWebPdf, 3.5 MB}
    Documentation/es/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf-es}
    Documentation/es/web/manuals.itexi:  @manualDevelWebPdf, 3.5 MB}
    Documentation/fr/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf-fr}
    Documentation/hu/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf-hu}
    Documentation/hu/web/manuals.itexi:  @manualDevelWebPdf-hu, 2 MB}
    Documentation/it/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf-it}
    Documentation/it/web/manuals.itexi:  @manualDevelWebPdf-it, 3.5 MB}
    Documentation/ja/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf}
    Documentation/ja/web/manuals.itexi:  @manualDevelWebPdf, 3.5 MB}
    Documentation/nl/web/manuals.itexi:  @manualDevelWebPdf-nl, 2 MB}
    Documentation/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf}
    Documentation/web/manuals.itexi:  @manualDevelWebPdf, 3.5 MB}
    Documentation/zh/web/community.itexi:@docLinkPdf{Web,web,@manualDevelWebPdf-zh}
    Documentation/zh/web/manuals.itexi:  @manualDevelWebPdf, 2 MB}
    
     

    Last edit: Federico Bruni 2017-03-08
  • Anonymous

    Anonymous - 2017-03-10

    Federico, when you said:

    "Note the missing -es extension in the third manual link.
    So it's up to translators to fix it."

    Do essentially you mean '..it's up to the translators to choose if they want to link to the English docs or not' ?

    Rather than being something to 'fix' (i.e. nothing is actually broken per se but that this is just a way to get round to not having a dead link to a doc that hasn't actually been translated?).

     
  • Federico Bruni

    Federico Bruni - 2017-03-10

    Yes, you understand correctly.
    I'll write to the translators list to bring attention on this.

    Some languages did not make a consistent choice: e.g czech, german and spanish doc links to the english web.pdf in manuals page and to the translated web.XX.pdf in community page.

     
  • Masamichi Hosoda

    I see.
    Thank you.

     
  • Anonymous

    Anonymous - 2017-03-11
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-03-11

    Unless anyone has any objections, this could have therefore gone on yesterday's countdown. So I am moving this along.

     
  • Anonymous

    Anonymous - 2017-03-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-03-13

    Patch counted down - please push.

     
  • Masamichi Hosoda

    • labels: --> Fixed_2_19_58
    • status: Started --> Fixed
    • Patch: push -->
     
  • Masamichi Hosoda

    I've pushed to staging.

    commit eca3d05456383fc0b451468ce1b21ed08229821f
    Issue 5083: Add making web.$(ISOLANG).pdf

     
  • Federico Bruni

    Federico Bruni - 2017-04-16
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.