Menu

#5080 Gracenotes at the start of a volta alternative now breaks autobeaming in the same way as in multipart music.

Verified
Critical
2017-04-03
2017-03-03
No

On 03/03/17 14:06, Sven Axelsson wrote:

Gracenotes at the start of a volta alternative now breaks autobeaming in
the same way as in multipart music. They need to be balanced by an
equivalent skip in order to work. This was not the case with 2.18.

\version "2.19.56"

\relative c'' {
\repeat volta 2 {
c8. c16 c4 c2 |
}
\alternative {
{ \grace c32 c8. c16 c4 c2 | }
{ c8. c16 c4 c2 | } % breaks
% { \grace s32 c8. c16 c4 c2 | } % works
}
c8. c16 c4 c2 |
}

Discussion

  • Anonymous

    Anonymous - 2017-03-03

    On 03/03/17 12:23, David Kastrup wrote:

    Sven Axelsson sven.axelsson@gmail.com writes:

    On 3 March 2017 at 11:53, Andrew Bernard andrew.bernard@gmail.com wrote:

    Hi Sven,

    Graces are a bit subtle. Try this:

    \version "2.19.56"

    \relative c'' {
    \repeat volta 2 {
    c8. c16 c4 c2 |
    }
    \alternative {
    { \grace { c32 } c8. c16 c4 c2 | }
    { \grace { s32 } c8. c16 c4 c2 | }
    }
    c8. c16 c4 c2 |
    }

    Ah, yes. I remember having to do that in multipart music, but not in
    alternatives. Is that something that have changed?

    Quite likely, yes. There was work for resetting the bar position to the
    previous value for each alternative in 2.19, courtesy yours truly. It
    would appear that I did not anticipate this kind of foreshortening.
    File a bug for this: it's different from the infamous issue 34 (even
    though the workaround looks identical) and should be fixable much more
    gracefully.

     
  • David Kastrup

    David Kastrup - 2017-03-03

    Issue 5080: pin measurePosition grace timing in alternatives

    Contains commits:

    Issue 5080/3: Regtest

    Issue 5080/2: pin measurePosition grace timing in alternatives

    Issue 5080/1: Comment fix for alternativeRestores

    http://codereview.appspot.com/320270043

     
  • David Kastrup

    David Kastrup - 2017-03-03
    • labels: --> Regression
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,3 @@
    -
     On 03/03/17 14:06, Sven Axelsson wrote:
     > Gracenotes at the start of a volta alternative now breaks autobeaming in
     > the same way as in multipart music. They need to be balanced by an
    
    • assigned_to: David Kastrup
    • Needs: -->
    • Type: --> Critical
     
  • Anonymous

    Anonymous - 2017-03-04
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-03-04

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-03-07
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-03-07

    Patch on countdown for March 10th,

     
  • Anonymous

    Anonymous - 2017-03-10
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-03-10

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2017-03-10
    • labels: Regression --> Regression, Fixed_2_19_57
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2017-03-10

    Pushed to staging as
    commit 904268628ec839b3b8265c7cbee3cac475c7c5a2
    Author: David Kastrup dak@gnu.org
    Date: Fri Mar 3 18:02:15 2017 +0100

    Issue 5080/3: Regtest
    

    commit 64f92f4f05d02b7dddb2a57f2c2880319ef74323
    Author: David Kastrup dak@gnu.org
    Date: Fri Mar 3 17:57:36 2017 +0100

    Issue 5080/2: pin measurePosition grace timing in alternatives
    

    commit 2cdbd8c4ecc339e2f0ef9d9498a556dda01a4b3a
    Author: David Kastrup dak@gnu.org
    Date: Fri Mar 3 17:55:56 2017 +0100

    Issue 5080/1: Comment fix for alternativeRestores
    
     
  • Graham Percival

    Graham Percival - 2017-04-03
    • status: Fixed --> Verified