Menu

#5079 Let \afterGrace start a Bottom context

Verified
Defect
2017-04-03
2017-02-28
No

Let \afterGrace start a Bottom context

Previously, an \afterGrace as the first expression of music outside of
an existing Bottom context caused quite weird results.

Also contains commits:

with-music-match: lists should match completely

Previously music properties that were matched to a list of wildcards
could contain fewer elements than the list they were matched to,
leading to an error when the wildcard variable was being assigned to.

Now the list lengths have to be matched exactly: a shorter pattern
than the actual list length of the matched property cannot match any
more.

Fix \displayLilyMusic \partcombine...

Strictly speaking this oversight in issue 4356 did not actually
manifest itself as a bug because of another bug masking it.

http://codereview.appspot.com/314590043

Discussion

  • Anonymous

    Anonymous - 2017-03-01
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-03-01

    Passes make, make check and a full make doc.

     
  • David Kastrup

    David Kastrup - 2017-03-03
    • Type: Enhancement --> Defect
     
  • Anonymous

    Anonymous - 2017-03-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-03-04

    Patch on countdown for March 7th.

     
  • Anonymous

    Anonymous - 2017-03-07
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-03-07

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2017-03-07
    • labels: --> Fixed_2_19_57
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2017-03-07

    Pushed to staging as
    commit d65c28e4c325cd3193c158bb92f6abf5e397aae1
    Author: David Kastrup dak@gnu.org
    Date: Sun Feb 26 20:45:22 2017 +0100

    Issue 5079/3: Let \afterGrace start a Bottom context
    
    Previously, an \afterGrace as the first expression of music outside of
    an existing Bottom context caused quite weird results.
    

    commit af3e0d104a70c3bba418f32583006ad31accd8a8
    Author: David Kastrup dak@gnu.org
    Date: Wed Mar 1 00:33:51 2017 +0100

    Issue 5079/2: with-music-match: lists should match completely
    
    Previously music properties that were matched to a list of wildcards
    could contain fewer elements than the list they were matched to,
    leading to an error when the wildcard variable was being assigned to.
    
    Now the list lengths have to be matched exactly: a shorter pattern
    than the actual list length of the matched property cannot match any
    more.
    

    commit 601ed4a98249291180c03db51cb515aa00aeb6a0
    Author: David Kastrup dak@gnu.org
    Date: Tue Feb 28 23:53:47 2017 +0100

    Issue 5079/1: Fix \displayLilyMusic \partcombine...
    
    Strictly speaking this oversight in issue 4356 did not actually
    manifest itself as a bug because of another bug masking it.
    
     
  • Graham Percival

    Graham Percival - 2017-04-03
    • status: Fixed --> Verified